Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subprojects do not copy common resources on runClient #228

Closed
rinOfTheStars opened this issue Aug 5, 2024 · 5 comments
Closed

Subprojects do not copy common resources on runClient #228

rinOfTheStars opened this issue Aug 5, 2024 · 5 comments

Comments

@rinOfTheStars
Copy link

rinOfTheStars commented Aug 5, 2024

Resources from the common project are not copied into the build/resources directories of platform subprojects when running the subprojects' respective LOADER/loom/runClient tasks. This isn't an immediate problem on (neo)forge as mixins are copied by the gradle scripts, but fabric and quilt expect the common mixin json which does not exist for them to use at runtime.

Intriguingly, this does not appear to be an issue in the compiled version of the mods—this might be an issue with the template buildscripts specifically? Not sure, tell me if I need to move this issue to that repo if that's the case

@rinOfTheStars
Copy link
Author

rinOfTheStars commented Aug 5, 2024

Appears to be a duplicate of architectury/architectury-templates#30, closing for now
Actually wait, no, this issue is a superset of that one. Oops.

@rhysdh540
Copy link

I don't think this is a loom issue, you just need to depend on the right output of the common module, like what happens here:
https://github.com/architectury/template-generator/blob/dev/src/templates/fabric/build.gradle#L38C5-L38C69

@rinOfTheStars
Copy link
Author

That's already present in the buildscripts, yet the issue happens regardless

@rinOfTheStars
Copy link
Author

Seems like the issue might be that the transformProductionForge and transformProductionQuilt tasks aren't being run as part of runClient (and presumably runServer), meaning this is for sure a buildscript issue.

@rinOfTheStars rinOfTheStars closed this as not planned Won't fix, can't repro, duplicate, stale Aug 5, 2024
@rinOfTheStars
Copy link
Author

Maybe it isn't a buildscript issue, actually? I have no clue at this point...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants