Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll-up and scroll-down keyboard shortcuts don't work #3091

Open
correctmost opened this issue Jan 9, 2025 · 9 comments · May be fixed by #3113
Open

Scroll-up and scroll-down keyboard shortcuts don't work #3091

correctmost opened this issue Jan 9, 2025 · 9 comments · May be fixed by #3113

Comments

@correctmost
Copy link
Contributor

Steps to reproduce

  1. Run archinstall
  2. Select "Timezone"
  3. Press ctrl + up
    --> Notice that the selection only moves up one item
  4. Press ctrl + down
    --> Notice that the selection only moves down one item

I would expect the selections to move up/down by a screen instead.

Version

This bug is present in 3.0.1 and the latest commit from master (c081f77)

@svartkanin
Copy link
Collaborator

Scrolling is only meant for preview windows as they do not have any interaction options.
For windows such as the time select pressing up and down achieves the same thing and there is a filter available as well

@correctmost
Copy link
Contributor Author

Oh, okay. I just tried ctrl + down in the "Save Configuration" window and it moves the selection down instead of scrolling the preview text on the side (the configuration text is long enough to scroll).

@svartkanin
Copy link
Collaborator

svartkanin commented Jan 9, 2025

Are you on the latest release? If possible could you try master as well.

Sorry just read that you did. Okay let me try to reproduce it

@svartkanin
Copy link
Collaborator

I just tried master and it seems to work fine in the "Save configuration" view pressing ctrl+up and ctrl+down.

Screencast_20250111_155530.mp4

@correctmost
Copy link
Contributor Author

Thanks for testing. I am still able to reproduce the issue on the "Save configuration" screen inside of a desktop VM and on a laptop (with commit e7f2a8c).

I added some debug() statements and see MenuKeys.MENU_UP and MenuKeys.MENU_DOWN keys when I press ctrl + up and ctrl + down.

I am using standard en-US keyboards. Is there anything else that could differ between our systems?

@svartkanin
Copy link
Collaborator

As it's a VM I wonder if the ctrl key is not passed through properly. Could you try any other shortcut that contains ctrl to see if that works?

@correctmost
Copy link
Contributor Author

Ctrl + h brings up the help dialog and ctrl + c brings up a reset prompt in "Disk configuration".

I see the same scroll issue on a laptop (no VMs involved), so I may have to add more debug statements to get more info.

@codefiles
Copy link
Contributor

@svartkanin
Do you use a terminal emulator for testing? I think it would be more appropriate to test in console. The ISO relies on the console so that is how most users will experience it. As this issue demonstrates, these environments will have differences in behavior.

@svartkanin
Copy link
Collaborator

@codefiles I was indeed testing on an emulator and managed to reproduce the issue on a console, thanks for pointing that out. It seems that the console is unable to combine any ctrl-up/down or even alt-up/down combinations.

I opted for using PgUp and PgDown for now as that seems to work.

@svartkanin svartkanin linked a pull request Jan 12, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants