Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate the logging boundary between Wasm and JS #1724

Open
blaine-arcjet opened this issue Sep 20, 2024 · 0 comments
Open

Investigate the logging boundary between Wasm and JS #1724

blaine-arcjet opened this issue Sep 20, 2024 · 0 comments
Assignees
@blaine-arcjet

Comments

@blaine-arcjet
Copy link
Contributor

During some profiling, I found that calling the debug() function inside Wasm and logging it out via JS was using more memory than I would expect. We should look into this and decide if the logging is worth crossing the boundary.
@blaine-arcjet blaine-arcjet mentioned this issue Oct 21, 2024
Merged
trunk-io bot pushed a commit that referenced this issue Oct 22, 2024
@blaine-arcjet
fix!: Return ERROR decision when fingerprint cannot be generated (#1990)
618a1ee 
This changes the SDK to return an `ERROR` decision if we cannot build the fingerprint based on the data provided to `protect()`.  This is a breaking change because we used to continue with an empty fingerprint, but that wasn't the correct behavior.

I've also regenerated the Analyze Wasm and we've removed the logging in an attempt to check performance/memory usage which we'll investigate with examples and users. Ref #1724

Closes #1801
@blaine-arcjet blaine-arcjet self-assigned this Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@blaine-arcjet blaine-arcjet

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@blaine-arcjet