Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there process for adding a site to the default origins list? #688

Closed
phptuts opened this issue Jan 29, 2022 · 5 comments
Closed

Is there process for adding a site to the default origins list? #688

phptuts opened this issue Jan 29, 2022 · 5 comments
Assignees

Comments

@phptuts
Copy link

phptuts commented Jan 29, 2022

Hi,

Thank you so much for developing the Arduino Agent. It's a fantastic tool!

I want to use it with ElectroBlocks, an open-source Arduino Blockly website. Is there a process on the list of default origins to use the Arduino Agent with the site automatically? I know it's a big ask, so no worries if the answer is no.

Thank you for your time.

Noah

@umbynos
Copy link
Contributor

umbynos commented Jan 31, 2022

Hi @phptuts, first of all congratulations on your project!
The allowed origins are currently listed in the config.ini file, currently the only way to add a new one is by manually add one in the config.ini file unfortunately

@phptuts
Copy link
Author

phptuts commented Feb 1, 2022

Thank you!! I appreciate that! @umbynos

Would you be open to a pr that allowed that? Would it be ok if it opened a web page like a debug page?

@umbynos
Copy link
Contributor

umbynos commented Feb 3, 2022

I would consider this issue solved since the topic of the issue has been answered to. Feel free to reopen it if you feel it hasn't. An answer to contribution question have been answered in this other issue

@umbynos umbynos closed this as completed Feb 3, 2022
@phptuts
Copy link
Author

phptuts commented Feb 4, 2022

@umbynos Thank you for your answer. Would you be open to a pr that user configuring their origin list? I would make it like the picture in the other issue.

image

@fstasi
Copy link

fstasi commented Feb 8, 2022

Hi @phptuts, the user can already edit the config.ini file (which is located alongside the agent executable), and add the origins they want.

We can update the relevant wiki page and better document how the user should add custom origins. This issue we just created will track this task.

Having a custom menu item to configure just the origins is definitely not a viable solution as we are creating and exception for a specific configuration that can and should be set in the config.ini file.

Also, adding a custom web ui has been determined not to be feasible because of this answer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants