Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equalize updateRepo with printerProfileRepo #324

Open
kloknibor opened this issue Jun 26, 2017 · 2 comments
Open

Equalize updateRepo with printerProfileRepo #324

kloknibor opened this issue Jun 26, 2017 · 2 comments
Labels

Comments

@kloknibor
Copy link
Contributor

Hi,

I see in start.sh we are looking for updaterepo in CONFIG_PROPS="${HOME}/3dPrinters/config.properties" but in %HOMEPATH%/3dPrinters/config.properties there is no updateRepo entry visable althoug this file does exist and for example contains : performedOneTimeInstall=true

For the updating start.bat to work it would be good to have updateRepo also available in the windows config.properties :)!

I must mention I haven't checked if this is working correctly on linux! Maybe we need to fix both.

For now I will use printerProfileRepo... ;)!

@WesGilster
Copy link
Contributor

WesGilster commented Jun 28, 2017

First off, I don't understand why there is any reason to have both a printerProfileRepo and updateRepo. Not sure if that was necessary.

As to your question about config.properties in the 3dPrinters directory, there is a good reason to do that. In that directory are the user specific settings that exist for any given user. The more commonly known settings are in the CWH root directory. What is important to note is that that config.properties will get overwritten on every install and upgrade of CWH. The user specific settings will not get overwritten when CWH is upgraded or installed.

@WesGilster WesGilster changed the title [BUG] Windows config.properties hasn't got updaterepo Equalize updateRepo with printerProfileRepo Jun 28, 2017
@WesGilster WesGilster added the bug label Jun 28, 2017
@kloknibor
Copy link
Contributor Author

Allright I agree, printerProfileRepo is just a bit confusing. I think it is good to have the repo in config.properties but maybe just call it simply "Repo" and we then get all our stuff from there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants