Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab Token Rotation Doesn't Automatically Reconfigure Webhooks #3459

Open
thomas-ribeiro-ifood opened this issue Feb 7, 2025 · 1 comment
Labels
bug Something isn't working

Comments

@thomas-ribeiro-ifood
Copy link

Describe the bug

Following the recent rotation of the GitLab token used by our Argo-Events source (GitLab), we encountered an incident. After updating the secret value via external secrets, the logs indicated that the source appeared to function correctly.

...,"msg":"received a request, processing it...",...

Upon further investigation, it was discovered that the webhook configurations had not been updated with the new token automatically. This necessitated manual intervention, where all existing webhooks had to be deleted to allow the EventSource to recreate them with the updated token configuration.

To Reproduce

  1. Create gitlab event source
  2. Create some trigger to display the message
  3. Rotate the gitlab token updating in your argo-events app
  4. At this time the trigger is not more dispatching

Expected behavior
After rotate the gitlab token, reconfigure webhooks

Environment (please complete the following information):

  • Kubernetes: v1.30.0
  • Argo Events: 1.7.5

Message from the maintainers:

If you wish to see this enhancement implemented please add a 👍 reaction to this issue! We often sort issues this way to know what to prioritize.

@thomas-ribeiro-ifood thomas-ribeiro-ifood added the bug Something isn't working label Feb 7, 2025
@Thomasr-02
Copy link
Contributor

👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants