Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify _ssl.c by merging PyArg_Parse("es", "ascii") with AC-generated argument parser #1

Open
arhadthedev opened this issue May 7, 2022 · 0 comments
Open

Simplify _ssl.c by merging PyArg_Parse("es", "ascii") with AC-generated argument parser #1

arhadthedev opened this issue May 7, 2022 · 0 comments

Comments

@arhadthedev
Copy link
Owner

arhadthedev commented May 7, 2022 •
edited
Loading

Simplify _ssl.c by merging PyArg_Parse("es", "ascii") with AC-generated argument parser

While sorting out how SSLSocket differentiates between a peer closed a connection and a peer downgraded its connection to plaintext so unwrap() is required I found a couple of immediately involved methods with 1/3 of payload and 2/3 of dedicated hostname decoding.

This PR delegates the decoding to Argument Clinic.
@arhadthedev arhadthedev moved this to In Progress in PR Drafts May 7, 2022
arhadthedev pushed a commit that referenced this issue Jun 8, 2022
@gpshead
pythongh-89455: Fix an uninitialized bool in exception print context. (…
861974b 
…python#91466)

Fix an uninitialized bool in exception print context.
    
`struct exception_print_context.need_close` was uninitialized.
    
Found by oss-fuzz in a test case running under the undefined behavior sanitizer.
    
https://oss-fuzz.com/testcase-detail/6217746058182656
    
```
Python/pythonrun.c:1241:28: runtime error: load of value 253, which is not a valid value for type 'bool'
    #0 0xbf2203 in print_chained cpython3/Python/pythonrun.c:1241:28
    #1 0xbea4bb in print_exception_cause_and_context cpython3/Python/pythonrun.c:1320:19
    #2 0xbea4bb in print_exception_recursive cpython3/Python/pythonrun.c:1470:13
    #3 0xbe9e39 in _PyErr_Display cpython3/Python/pythonrun.c:1517:9
```
    
Pretty obvious what the ommission was upon code inspection.
@arhadthedev arhadthedev mentioned this issue Feb 11, 2023
Closed
arhadthedev pushed a commit that referenced this issue Oct 1, 2023
@vstinner
Revert "pythongh-46376: Return existing pointer when possible in ctyp…
5a79d2a 
…es (#1… (python#108688)

This reverts commit 08447b5.

Revert also _ctypes.c changes of the PyDict_ContainsString() change,
commit 6726626.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
No open projects
PR Drafts
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@arhadthedev