Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An option to dismiss the banner even if they click the "yes" button #16

Open
ericloyd opened this issue Sep 21, 2024 · 2 comments
Open
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@ericloyd
Copy link

Maybe I'm missing something, but if I make a banner that only shows on the home page that says (for example) "take me to the store" and someone clicks on it, then they go to the store. But if they go back to the home page, or enter the homepage URL again, or click on a link on the store that takes them back to the home page, the banner doesn't realize that they went to the store and still shows the "do you want to go to the store?" banner.

I'd an option to be able to have the banner removed if they clicked the "yes" action as well as if they click the "no" action.

But like I said - I may be missing this functionality somehow.

@aricooperdavis aricooperdavis added enhancement New feature or request good first issue Good for newcomers labels Sep 25, 2024
@aricooperdavis aricooperdavis self-assigned this Sep 25, 2024
@aricooperdavis
Copy link
Owner

aricooperdavis commented Sep 25, 2024

You're not missing anything, this behavior isn't an option at the moment.

It's an easy addition, happy to accept a PR, otherwise leave it with me.

@ericloyd
Copy link
Author

I'll wait for you. I'm not a developer. Or at least, I'm not one you want doing PRs on public code. 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants