From 1408772f325edf44fb88b84fd2655ba5d8346d40 Mon Sep 17 00:00:00 2001 From: VitthalMagadum Date: Wed, 25 Sep 2024 02:18:03 -0400 Subject: [PATCH] issue_811 Handling review comments: updated the pylint ignore and doctsring --- anta/tests/routing/bgp.py | 7 +++++-- examples/tests.yaml | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/anta/tests/routing/bgp.py b/anta/tests/routing/bgp.py index 2c4735eac..5d866236c 100644 --- a/anta/tests/routing/bgp.py +++ b/anta/tests/routing/bgp.py @@ -18,6 +18,9 @@ from anta.models import AntaCommand, AntaTemplate, AntaTest from anta.tools import get_item, get_value +# pylint: disable=C0302 +# TODO: Refactor to reduce the number of lines in this module later + def _add_bgp_failures(failures: dict[tuple[str, str | None], dict[str, Any]], afi: Afi, safi: Safi | None, vrf: str, issue: str | dict[str, Any]) -> None: """Add a BGP failure entry to the given `failures` dictionary. @@ -1627,8 +1630,8 @@ class VerifyBGPRouteOrigin(AntaTest): Expected Results ---------------- - * Success: The test will pass if the BGP route's origin matches expected origin type. - * Failure: The test will fail if the BGP route's origin does not matches with expected origin type or BGP route entry(s) not found. + * Success: The test will pass if the BGP route's origin matches expected origin type and next-hop address. + * Failure: The test will fail if the BGP route's origin does not matches with expected origin type, next-hop address or BGP route entry(s) not found. Examples -------- diff --git a/examples/tests.yaml b/examples/tests.yaml index ca579c0d8..6b2b89c8c 100644 --- a/examples/tests.yaml +++ b/examples/tests.yaml @@ -694,4 +694,4 @@ anta.tests.routing: - endpoint: 1.0.0.14/32 vias: - type: ip - nexthop: 1.1.1.1 \ No newline at end of file + nexthop: 1.1.1.1