Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use Forward Annotations for AntaTest.Input #994

Open
mtache opened this issue Jan 7, 2025 · 0 comments
Open

refactor: use Forward Annotations for AntaTest.Input #994

mtache opened this issue Jan 7, 2025 · 0 comments

Comments

@mtache
Copy link
Collaborator

mtache commented Jan 7, 2025

These are notes from #937

Refactor the code to use https://docs.pydantic.dev/2.10/concepts/forward_annotations/ for AntaTest.Input subclasses references.

Review the typing of TestResult.inputs to be InstanceOf[AntaTest.Input] instead of InstanceOf[BaseModel]. There is currently a recursive import issue. We should move AntaTest.Input elsewhere.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mtache