Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge app-config and config packages #390

Open
louisinger opened this issue Nov 28, 2024 · 1 comment · May be fixed by #391
Open

Merge app-config and config packages #390

louisinger opened this issue Nov 28, 2024 · 1 comment · May be fixed by #391
Assignees
@aruokhai
Labels
good first issue Good for newcomers

Comments

@louisinger
Copy link
Collaborator

The app-config pkg and the config pkg are using a duplicated "Config" struct, making it annoying to update the config variables.

Let's drop app-config and merge it into config package.
@louisinger louisinger added the good first issue Good for newcomers label Nov 28, 2024
@aruokhai
Copy link
Contributor

Taking this

@aruokhai aruokhai linked a pull request Dec 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aruokhai aruokhai

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Consolidate Duplicate Server appConfig and Config Structure aruokhai/ark
2 participants
@aruokhai @louisinger