From a514d519ce918963b300dbfd2bad725ad3e53be8 Mon Sep 17 00:00:00 2001
From: Andrew Zitek-Estrada <1497456+z-tech@users.noreply.github.com>
Date: Mon, 3 Mar 2025 20:34:58 +0100
Subject: [PATCH 1/2] z-tech/fix-werror-on-must-use-annotation (#946)

---
 ec/src/models/short_weierstrass/affine.rs   | 1 -
 ec/src/models/twisted_edwards/affine.rs     | 1 -
 ff/src/fields/models/fp/mod.rs              | 1 -
 ff/src/fields/models/quadratic_extension.rs | 1 -
 4 files changed, 4 deletions(-)

diff --git a/ec/src/models/short_weierstrass/affine.rs b/ec/src/models/short_weierstrass/affine.rs
index 75d0e1b3d..63b179eec 100644
--- a/ec/src/models/short_weierstrass/affine.rs
+++ b/ec/src/models/short_weierstrass/affine.rs
@@ -238,7 +238,6 @@ impl<P: SWCurveConfig> AffineRepr for Affine<P> {
 
     /// Multiplies this element by the cofactor and output the
     /// resulting projective element.
-    #[must_use]
     fn mul_by_cofactor_to_group(&self) -> Self::Group {
         P::mul_affine(self, Self::Config::COFACTOR)
     }
diff --git a/ec/src/models/twisted_edwards/affine.rs b/ec/src/models/twisted_edwards/affine.rs
index 3481b05c5..48670f4c4 100644
--- a/ec/src/models/twisted_edwards/affine.rs
+++ b/ec/src/models/twisted_edwards/affine.rs
@@ -184,7 +184,6 @@ impl<P: TECurveConfig> AffineRepr for Affine<P> {
 
     /// Multiplies this element by the cofactor and output the
     /// resulting projective element.
-    #[must_use]
     fn mul_by_cofactor_to_group(&self) -> Self::Group {
         P::mul_affine(self, Self::Config::COFACTOR)
     }
diff --git a/ff/src/fields/models/fp/mod.rs b/ff/src/fields/models/fp/mod.rs
index 87ceda04e..32b74ee1d 100644
--- a/ff/src/fields/models/fp/mod.rs
+++ b/ff/src/fields/models/fp/mod.rs
@@ -677,7 +677,6 @@ impl<P: FpConfig<N>, const N: usize> Display for Fp<P, N> {
 impl<P: FpConfig<N>, const N: usize> Neg for Fp<P, N> {
     type Output = Self;
     #[inline]
-    #[must_use]
     fn neg(mut self) -> Self {
         P::neg_in_place(&mut self);
         self
diff --git a/ff/src/fields/models/quadratic_extension.rs b/ff/src/fields/models/quadratic_extension.rs
index 914ea3b4a..ec901c5b6 100644
--- a/ff/src/fields/models/quadratic_extension.rs
+++ b/ff/src/fields/models/quadratic_extension.rs
@@ -570,7 +570,6 @@ impl<P: QuadExtConfig> From<bool> for QuadExtField<P> {
 impl<P: QuadExtConfig> Neg for QuadExtField<P> {
     type Output = Self;
     #[inline]
-    #[must_use]
     fn neg(mut self) -> Self {
         self.c0.neg_in_place();
         self.c1.neg_in_place();

From 9c3cc5355fb6f7cdaa58f6f9f92b2c0328dba3ac Mon Sep 17 00:00:00 2001
From: Thomas Coratger <60488569+tcoratger@users.noreply.github.com>
Date: Tue, 4 Mar 2025 01:17:56 +0100
Subject: [PATCH 2/2] rm useless LegendreSymbol import (#912)

Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
---
 ff/src/fields/models/fp/mod.rs | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/ff/src/fields/models/fp/mod.rs b/ff/src/fields/models/fp/mod.rs
index 32b74ee1d..26701ae48 100644
--- a/ff/src/fields/models/fp/mod.rs
+++ b/ff/src/fields/models/fp/mod.rs
@@ -320,16 +320,14 @@ impl<P: FpConfig<N>, const N: usize> Field for Fp<P, N> {
 
     #[inline]
     fn legendre(&self) -> LegendreSymbol {
-        use crate::fields::LegendreSymbol::*;
-
         // s = self^((MODULUS - 1) // 2)
         let s = self.pow(Self::MODULUS_MINUS_ONE_DIV_TWO);
         if s.is_zero() {
-            Zero
+            LegendreSymbol::Zero
         } else if s.is_one() {
-            QuadraticResidue
+            LegendreSymbol::QuadraticResidue
         } else {
-            QuadraticNonResidue
+            LegendreSymbol::QuadraticNonResidue
         }
     }