Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve LDT API #5

Open
4 tasks
tsunrise opened this issue Oct 5, 2021 · 0 comments
Open
4 tasks

Improve LDT API #5

tsunrise opened this issue Oct 5, 2021 · 0 comments

Comments

@tsunrise
Copy link
Member

tsunrise commented Oct 5, 2021

Summary

First, we need to make clear in the doc that the FRI in this repo is simply a round function. The complete FRI function requires an IOP system, and has been implemented as a built-in feature in ark-bcs library.

As I work on the ark-bcs code which uses this library, I do think we need to rename some parameters' name. For example, see the following function signature

pub fn consistency_check(
        fri_parameters: &FRIParameters<F>,
        queried_coset_indices: &[usize],
        queries: &[Radix2CosetDomain<F>],
        queried_evaluations: &[Vec<F>],
        alphas: &[F],
        final_polynomial_domain: &Radix2CosetDomain<F>,
        final_polynomial: &DensePolynomial<F>,

queried_coset_indices and queries are very confusing name. We need to specify where they come from, and the meaning of them.


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant