Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[META] TODOs #45

Open
5 of 7 tasks
asamuzaK opened this issue Jan 15, 2025 · 6 comments
Open
5 of 7 tasks

[META] TODOs #45

asamuzaK opened this issue Jan 15, 2025 · 6 comments

Comments

@asamuzaK
Copy link
Owner

asamuzaK commented Jan 15, 2025

See #41

Future TODOs

This code was not particularly type-safe from the start, so there's a myriad of type-casting and ignoring TS that's not ideal.

At some point we should:

Ref:

@asamuzaK
Copy link
Owner Author

@crutchcorn
One question.
When is .nvmrc used? Can we remove?

@crutchcorn
Copy link
Contributor

Don't remove. It's used in CI

@asamuzaK
Copy link
Owner Author

Then is it okay to change value to lts/*?

@crutchcorn
Copy link
Contributor

Truthfully idk. Lemme check and come back some time later

@asamuzaK
Copy link
Owner Author

Thanks, no need to hurry.

@asamuzaK
Copy link
Owner Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants