Skip to content
This repository has been archived by the owner on Dec 28, 2022. It is now read-only.

The foldable details summary div doesn't work #299

Open
Foadsf opened this issue Oct 18, 2019 · 5 comments
Open

The foldable details summary div doesn't work #299

Foadsf opened this issue Oct 18, 2019 · 5 comments

Comments

@Foadsf
Copy link

Foadsf commented Oct 18, 2019

Description

The foldable directive doesn't work.

  • Atom version: 1.40.1
  • OS: Windows 10
  • asciidoc-preview version: 2.13.1
  • language-asciidoc version: 1.11.0

Screenshots

the same code in both Atom and VSCode:

2019-10-18_12-50-17

Syntax example

+++ <details><summary> +++
some description
+++ </summary><div> +++
this
is
going
to be
folded
+++ </div></details> +++

the original source code can be found here.

@ggrossetie
Copy link
Member

With the latest version of Asciidoctor you can write the following:

.some description
[%collapsible]
====
this
is
going
to be
folded
====

collapse

@Foadsf
Copy link
Author

Foadsf commented Oct 18, 2019

So the former syntax is deprecated? I prefer not to touch that code at the moment!

@ggrossetie
Copy link
Member

Yes.
Using passthrough to include raw HTML is not recommended because now your document is tightly coupled with the output.

@Foadsf
Copy link
Author

Foadsf commented Oct 18, 2019

@Mogztter mentioned your point here as well. That page, at least for me is the first google search result when searching for "asciidoc collapsible".

@ggrossetie
Copy link
Member

Thanks! For reference it was introduced in Asciidoctor 2.0.0: https://github.com/asciidoctor/asciidoctor/releases/tag/v2.0.0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants