-
Notifications
You must be signed in to change notification settings - Fork 42
Images do not refresh. #95
Comments
My first thought is whether this is an issue in Atom. We could always append a query string to the images using JavaScript to force them to reload...perhaps when the tab is opened. |
Running into the same issue currently; is there anything I can do to work around this problem? |
I have the same issue and this is quite annoying. |
Does the same thing happen in the Markdown preview by chance? |
Can confirm as well. A restart of Atom is needed to refresh the image. Simply toggling the preview is not enough. I've tried it with the markdown preview, and it shows the same behavior. |
Perhaps we can append a timestamp to the query string of the image URL. Not pretty, but if this is a low-level issue in Atom, that might allow us to work around it. |
Any idea if this would impact other forms of caching/optimization by Atom? Maybe a hash would be better (more computing though)? If the time-stamp is only updated when the plugin is toggled, I guess it should work, rather than continuously updating cached images when the preview reloads. |
Can we find the upstream bug? |
It's not a bug but a feature ;) |
Looks like adding a querystring/fragment is what the Markdown guys did as well: https://github.com/Galadirith/markdown-preview-plus/issues/49 |
I have created a PR with this trick but currently the images don't reload only when they change. To do automatically refresh when changed we must watch the images. Related to #136. |
Both, if you change the document the images are automatically reload, if you only change the images you must toggle. |
When including images in an asciidoc document they do not get refreshed when the
document is updated. Even if I close the tab showing the preview and reopen it the old
images are still displayed.
The text was updated successfully, but these errors were encountered: