Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR]: s3_sync: Add support to provide the name of the destination file #83

Open
hashken opened this issue Oct 9, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@hashken
Copy link

hashken commented Oct 9, 2024

What is the current behavior?

Right now, we are able to provide the bucket and prefix to which a file should be copied to. But, the name of the file remains the same as what is given as input.

Describe the feature

  • When we copy a file to s3, sometimes we want to be able to control the name of the file that is uploaded.
  • If the file name is static, it's easy to first use copy_file to rename it and then invoke s3_sync.
  • But, if we want the file name to be stamped, there is currently no way to achieve this.
  • Provide the ability to pass the destination file name
    • Might be nice to have 2 separate args like filename and filename_file, so that we can either directly give the static name or use expand_template to populate the stamped name in a file.
  • We should do a check that / is not present in the filename as that would make part of it as a prefix.
@hashken hashken added the enhancement New feature or request label Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant