Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment must be not actual #68

Open
SergeyKanzhelev opened this issue Nov 5, 2019 · 0 comments
Open

Comment must be not actual #68

SergeyKanzhelev opened this issue Nov 5, 2019 · 0 comments

Comments

@SergeyKanzhelev
Copy link
Contributor

... as we have a setter now and already using it

// Once we have public Activity.Current setter (https://github.com/dotnet/corefx/issues/29207) this method will be
// simplified to just assign Current if is was lost.
// In the mean time, we are creating child Activity to restore the context. We have to send
// event with this Activity to tracing system. It created a lot of issues for listeners as
// we may potentially have a lot of them for different stages.
// To reduce amount of events, we only care about ExecuteRequestHandler stage - restore activity here and
// stop/report it to tracing system in EndRequest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant