Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No-detection mode interferes with '--partition-multithreshold=1' #576

Open
mkuemmel opened this issue Mar 8, 2024 · 2 comments
Open

No-detection mode interferes with '--partition-multithreshold=1' #576

mkuemmel opened this issue Mar 8, 2024 · 2 comments
Assignees
Labels

Comments

@mkuemmel
Copy link
Collaborator

mkuemmel commented Mar 8, 2024

Looks like in 0.21 and the current develop requires partition-multithreshold switched off, and the default, which is on, leads to errors as discussed in #575 .

I consider this as a bug, and in no-detection mode this parameter should not be considered.

@marcschefer
Copy link
Member

Yes, indeed multithresholding can only work if we have a detection image.

I think overall what we are missing is some kind of configuration validation system. We've had similar problems where we'd like to disable some combinations of options or print warnings.

The configuration system uses many configuration classes that are supposed to be modular and have the minimum of dependencies possible. Adding such rules to the current system is going to create a mess.

@mkuemmel
Copy link
Collaborator Author

mkuemmel commented Mar 8, 2024

Yep, I think we sometimes tried to solve this on a small scale with dependencies and then errors. I think the more options we have and the more new branches such as the no-detection mode we this gets more complicated.

At least we know now that there is a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants