Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create global workflow that informs PR author about merge conflicts #181

Open
derberg opened this issue Sep 22, 2022 · 8 comments
Open

create global workflow that informs PR author about merge conflicts #181

derberg opened this issue Sep 22, 2022 · 8 comments
Labels
enhancement New feature or request

Comments

@derberg
Copy link
Member

derberg commented Sep 22, 2022

Reason/Context

Sometimes PRs get merge conflicts. No notifications tell the PR creator about it. This causes some PRs to hang for some time. It affects release branches the most

Description

We need workflow, that once it detects merge conflict on a PR, it posts a comment in PR and mentions the author. The comment should inform the author that there is a merge conflict (this will trigger notification).

It should not be annoying and duplicate comments, so we can inspire on #175 and:

  • put new comments only if non exists so far
  • delete comment if merge conflict is resolved

Bonus:
Maybe some tips on what is the best way to solve the merge conflict 🤔 good and bad practices.

Super bonus:
Additional workflow that anyone can trigger by adding comments like /rebase or /solve_conflict (/sf) would trigger a workflow that tries to solve the conflict in an automated way. Something to explore

@derberg derberg added the enhancement New feature or request label Sep 22, 2022
@github-actions
Copy link

github-actions bot commented Feb 9, 2023

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 9, 2023
@sambhavgupta0705
Copy link
Member

Hey @derberg ,I would like to work on this issue.

Copy link
Member Author

derberg commented Mar 23, 2023

@sambhavgupta0705 please go ahead

@chinma-yyy
Copy link

Hey @sambhavgupta0705 are you still working on this?

@sambhavgupta0705
Copy link
Member

No ,@chinma-yyy

@chinma-yyy
Copy link

No ,@chinma-yyy

Hey @derberg , I would like to work on this issue. Should I go ahead?

Copy link
Member Author

derberg commented Jun 27, 2023

sure, please

@chinma-yyy
Copy link

sure, please

Yup, sorry for late reply was on a vacation lately ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants
@derberg @sambhavgupta0705 @chinma-yyy and others