Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure automated bumps ignore spec and bindings repos #264

Closed
derberg opened this issue Dec 13, 2023 · 6 comments · Fixed by #265
Closed

Make sure automated bumps ignore spec and bindings repos #264

derberg opened this issue Dec 13, 2023 · 6 comments · Fixed by #265
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers

Comments

@derberg
Copy link
Member

derberg commented Dec 13, 2023

in bump workflow:

  • add spec and bindings as comma separated repos
  • remove html-template

https://github.com/asyncapi/.github/blob/master/.github/workflows/bump.yml#L34

This is due to make sure no releases take place in these repos just because they have some testing scripts, no real packages to release

details: https://asyncapi.slack.com/archives/C0230UAM6R3/p1702471398660389
@derberg derberg added the enhancement New feature or request label Dec 13, 2023
@derberg
Copy link
Member Author

derberg commented Dec 13, 2023

/gfi cicd

@asyncapi-bot
Copy link

Hey @derberg, your message doesn't follow the requirements, you can try /help.

@derberg
Copy link
Member Author

derberg commented Dec 13, 2023

/help

@asyncapi-bot
Copy link

Hello, @derberg! 👋🏼

I'm 🧞🧞🧞 Genie 🧞🧞🧞 from the magic lamp. Looks like somebody needs a hand!

At the moment the following comments are supported in issues:

  • /good-first-issue {js | ts | java | go | docs | design | ci-cd} or /gfi {js | ts | java | go | docs | design | ci-cd} - label an issue as a good first issue.
    example: /gfi js or /good-first-issue ci-cd

@derberg
Copy link
Member Author

derberg commented Dec 13, 2023

/gfi ci-cd

@asyncapi-bot asyncapi-bot added area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Dec 13, 2023
@ankur0904
Copy link
Contributor

@derberg Can I make the PR?

@ankur0904 ankur0904 mentioned this issue Dec 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/ci-cd Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: make bump workflow to ignore spec and bindings ankur0904/.github
3 participants
@derberg @asyncapi-bot @ankur0904