Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Checkout on the New PR and Issues workflow causes it to fail #299

Closed
2 tasks done
KhudaDad414 opened this issue Jun 3, 2024 · 1 comment · Fixed by #300
Closed
2 tasks done

[BUG] Checkout on the New PR and Issues workflow causes it to fail #299

KhudaDad414 opened this issue Jun 3, 2024 · 1 comment · Fixed by #300
Labels
bug Something isn't working

Comments

@KhudaDad414
Copy link
Member

Describe the bug.

Since we are using PNPM in studio, this workflow is failing.
https://github.com/asyncapi/studio/actions/runs/9357419699

Expected behavior

It should work as expected and workflow shouldn't be dependent on the package manager.
I think the problem is that we checkout the repo in the workflow here, here and here.

since the action is not dependent on the repo's content, we shouldn't checkout the repo.

Screenshots

...

How to Reproduce

...

🥦 Browser

None

👀 Have you checked for similar open issues?

  • I checked and didn't find similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue ?

Yes I am willing to submit a PR!

@KhudaDad414 KhudaDad414 added the bug Something isn't working label Jun 3, 2024
@derberg
Copy link
Member

derberg commented Jun 4, 2024

yeah, probably a left over from a time where we didn't use .github based action. Try to remove these checkouts first I studio and if all works, open PR here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants