Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new feature from Generator to support templates hosted as private packages #1081

Closed
derberg opened this issue Jan 22, 2024 · 7 comments · Fixed by #1399
Closed

Enable new feature from Generator to support templates hosted as private packages #1081

derberg opened this issue Jan 22, 2024 · 7 comments · Fixed by #1399
Labels
enhancement New feature or request released

Comments

@derberg
Copy link
Member

derberg commented Jan 22, 2024

Reason/Context

We just released a new feature in Generator -> https://www.asyncapi.com/docs/tools/generator/using-private-template

Description

Would be great to enable new flags in asyncapi generate fromTemplate command that enable user to pass custom registry.url and specific authorization method, like registry.auth or registry.token

@Souvikns I think it is a nice, pretty simple new feature that would be good for onboarding potential new maintainer as it is typical enhancement to existing command - so maintainer candidate learns code from perspective of commands and their tests

@derberg derberg added the enhancement New feature or request label Jan 22, 2024
@Shiva953
Copy link
Contributor

would like to take this up!

@Shiva953
Copy link
Contributor

Shiva953 commented Jan 24, 2024

BTW, should registry.auth and registry.token have a default value, in case none is provided?

Also, should we take the registry.auth as a base64 encoded string value, or take it in the form of "username:password" and then convert it to a base64 encoded value?

@AayushSaini101
Copy link
Contributor

@derberg Is it available to work, I can complete this

@derberg
Copy link
Member Author

derberg commented Apr 22, 2024

yeah, I guess so, @Shiva953 in related PR do not respons 2 weeks already

@AayushSaini101
Copy link
Contributor

yeah, I guess so, @Shiva953 in related PR do not respons 2 weeks already
Thanks @derberg

@AayushSaini101
Copy link
Contributor

@Amzani @derberg Started working on it creating a draft PR

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants