Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Add metadata for metrics collection in remaining commands #1357

Closed
12 tasks done
peter-rr opened this issue Apr 9, 2024 · 1 comment · Fixed by #1431
Closed
12 tasks done

[CLI] Add metadata for metrics collection in remaining commands #1357

peter-rr opened this issue Apr 9, 2024 · 1 comment · Fixed by #1431
Labels
enhancement New feature or request released

Comments

@peter-rr
Copy link
Member

peter-rr commented Apr 9, 2024

Why do we need this improvement?

We need to add metadata to all the commands for metrics collection as we already did in this POC for the following commands:

  • asyncapi validate
  • asyncapi convert
  • asyncapi bundle
  • asyncapi optimize
  • asyncapi generate fromTemplate
  • asyncapi new file

How will this change help?

This change will allow us to collect metrics for all the existing commands, in those cases in which makes sense.

Screenshots

No response

How could it be implemented/designed?

We will collect the metadata according to what we defined for the POC. We'll implement the changes for the following commands:

  • asyncapi config analytics
  • asyncapi start studio
  • asyncapi new glee
  • asyncapi diff

Not sure if makes sense to add more commands to the list. Feel free to suggest any change or idea about the topic 😄
cc @Amzani @KhudaDad414

🚧 Breaking changes

No

👀 Have you checked for similar open issues?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

Yes I am willing to submit a PR!

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 1.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants