Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for proxy #862

Open
mamyn0va opened this issue Oct 24, 2023 · 12 comments
Open

Add support for proxy #862

mamyn0va opened this issue Oct 24, 2023 · 12 comments
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers

Comments

@mamyn0va
Copy link

Reason/Context

Please try answering few of those questions

  • The CLI is totally unusable behind a proxy

Description

Please try answering few of those questions

  • The best would be to use env vars http_proxy and https_proxy
@mamyn0va mamyn0va added the enhancement New feature or request label Oct 24, 2023
@github-actions
Copy link
Contributor

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Feb 22, 2024
@Souvikns Souvikns removed the stale label Feb 22, 2024
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Jun 22, 2024
@Amzani
Copy link
Collaborator

Amzani commented Jul 5, 2024

still relevant

@Amzani
Copy link
Collaborator

Amzani commented Jul 5, 2024

/gfi ts

@asyncapi-bot asyncapi-bot added area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. good first issue Good for newcomers labels Jul 5, 2024
@github-actions github-actions bot removed the stale label Jul 6, 2024
@AayushSaini101
Copy link
Contributor

@Amzani @mamyn0va Can you tell me the proper steps to produce the error?

@Amzani
Copy link
Collaborator

Amzani commented Jul 23, 2024

@AayushSaini101 if you setup an HTTP proxy and try asyncapi validate https://raw.githubusercontent.com/asyncapi/spec/master/examples/streetlights-kafka-asyncapi.yml it fails.

@zeppe
Copy link

zeppe commented Aug 24, 2024

this impacts me, too. From a cursory look the project (this one and https://github.com/asyncapi/generator) use node-fetch that doesn't support proxies from environment variables etc. need to be passed in.

@AayushSaini101
Copy link
Contributor

AayushSaini101 commented Aug 25, 2024

Reason/Context

Please try answering few of those questions

  • The CLI is totally unusable behind a proxy

Description

Please try answering few of those questions

  • The best would be to use env vars http_proxy and https_proxy

@Amzani we can allow two parameters in cli that can support proxy:
set HTTP_PROXY=http://your-proxy-server:port
set HTTPS_PROXY=http://your-proxy-server:port

@zeppe
Copy link

zeppe commented Aug 25, 2024

Sounds good to me. Only note, consider supporting lowercase and the all_proxy, no_proxy env for ease of use.

@AayushSaini101
Copy link
Contributor

This is the implementation plan:

  • Extend the asyncapi config command to add following parameters .
  • http_proxy, https_proxy, ftp_proxy takes a value http://your-proxy-server:your-port" that add proxy env in the current session of terminal
  • no_proxy will remove cleanup the value from the session.

@Souvikns @Amzani @Shurtu-gal If this good for you, Can we submit this issue in the upcoming bounty program ? I would like to work on this. Submission link: https://github.com/orgs/asyncapi/discussions/963#discussioncomment-10495474 thanks :)

@AayushSaini101
Copy link
Contributor

We have decided with @Souvikns to move this issue with mentorship program

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/typescript Specify what technical area given issue relates to. Its goal is to ease filtering good first issues. enhancement New feature or request good first issue Good for newcomers
Projects
Status: Backlog
Development

No branches or pull requests

6 participants