From 69febbb8578070cc3a542a458ef34b5668e8fa5e Mon Sep 17 00:00:00 2001
From: utnim2 <mintugogoi567@gmail.com>
Date: Mon, 23 Sep 2024 23:29:42 +0530
Subject: [PATCH 1/3] completed the cli support for conversion

---
 docs/usage.md                        |  8 ++--
 src/commands/convert.ts              | 13 +++++-
 src/core/flags/convert.flags.ts      |  2 +-
 test/fixtures/postman-collection.yml | 38 +++++++++++++++++
 test/integration/convert.test.ts     | 63 ++++++++++++++++++++++++++++
 5 files changed, 117 insertions(+), 7 deletions(-)
 create mode 100644 test/fixtures/postman-collection.yml

diff --git a/docs/usage.md b/docs/usage.md
index d61d7012f91..44de9695d65 100644
--- a/docs/usage.md
+++ b/docs/usage.md
@@ -308,7 +308,7 @@ _See code: [src/commands/config/versions.ts](https://github.com/asyncapi/cli/blo
 
 ## `asyncapi convert [SPEC-FILE]`
 
-Convert asyncapi documents older to newer versions or OpenAPI documents to AsyncAPI
+Convert asyncapi documents older to newer versions or OpenAPI | postman-collection documents to AsyncAPI
 
 ```
 USAGE
@@ -318,12 +318,12 @@ ARGUMENTS
   SPEC-FILE  spec path, url, or context-name
 
 FLAGS
-  -f, --format=<option>         (required) [default: asyncapi] Specify the format to convert from (openapi or asyncapi)
-                                <options: openapi|asyncapi>
+  -f, --format=<option>         (required) [default: asyncapi] Specify the format to convert from (openapi or asyncapi or postman-collection)
+                                <options: openapi|asyncapi|postman-collection>
   -h, --help                    Show CLI help.
   -o, --output=<value>          path to the file where the result is saved
   -p, --perspective=<option>    [default: server] Perspective to use when converting OpenAPI to AsyncAPI (client or
-                                server). Note: This option is only applicable for OpenAPI to AsyncAPI conversions.
+                                server). Note: This option is only applicable for OpenAPI | postman-collection to AsyncAPI conversions.
                                 <options: client|server>
   -t, --target-version=<value>  [default: 3.0.0] asyncapi version to convert to
 
diff --git a/src/commands/convert.ts b/src/commands/convert.ts
index 4386cb92d1b..a528c2c8b80 100644
--- a/src/commands/convert.ts
+++ b/src/commands/convert.ts
@@ -5,7 +5,7 @@ import Command from '../core/base';
 import { ValidationError } from '../core/errors/validation-error';
 import { load } from '../core/models/SpecificationFile';
 import { SpecificationFileNotFound } from '../core/errors/specification-file';
-import { convert, convertOpenAPI } from '@asyncapi/converter';
+import { convert, convertOpenAPI, convertPostman } from '@asyncapi/converter';
 import type { AsyncAPIConvertVersion, OpenAPIConvertVersion } from '@asyncapi/converter';
 import { cyan, green } from 'picocolors';
 
@@ -16,7 +16,7 @@ import { convertFlags } from '../core/flags/convert.flags';
 const latestVersion = Object.keys(specs.schemas).pop() as string;
 
 export default class Convert extends Command {
-  static description = 'Convert asyncapi documents older to newer versions or OpenAPI documents to AsyncAPI';
+  static description = 'Convert asyncapi documents older to newer versions or OpenAPI/postman-collection documents to AsyncAPI';
 
   static flags = convertFlags(latestVersion);
 
@@ -54,6 +54,15 @@ export default class Convert extends Command {
         } else if (this.specFile.getFileURL()) {
           this.log(`🎉 The URL ${cyan(this.specFile.getFileURL())} has been successfully converted to version ${green(flags['target-version'])}!!`);
         }
+      } else {
+        convertedFile = convertPostman(this.specFile.text(), '3.0.0', {
+          perspective: flags['perspective'] as 'client' | 'server'
+        });
+        if (this.specFile.getFilePath()) {
+          this.log(`🎉 The ${cyan(this.specFile.getFilePath())} file has been successfully converted to asyncapi of version ${green(flags['target-version'])}!!`);
+        } else if (this.specFile.getFileURL()) {
+          this.log(`🎉 The URL ${cyan(this.specFile.getFileURL())} has been successfully converted to asyncapi of version ${green(flags['target-version'])}!!`);
+        }
       }
 
       if (typeof convertedFile === 'object') {
diff --git a/src/core/flags/convert.flags.ts b/src/core/flags/convert.flags.ts
index c747368883f..8dd78db3184 100644
--- a/src/core/flags/convert.flags.ts
+++ b/src/core/flags/convert.flags.ts
@@ -7,7 +7,7 @@ export const convertFlags = (latestVersion: string) => {
     format: Flags.string({
       char: 'f',
       description: 'Specify the format to convert from (openapi or asyncapi)',
-      options: ['openapi', 'asyncapi'],
+      options: ['openapi', 'asyncapi', 'postman-collection'],
       required: true,
       default: 'asyncapi',
     }),
diff --git a/test/fixtures/postman-collection.yml b/test/fixtures/postman-collection.yml
new file mode 100644
index 00000000000..0c232306504
--- /dev/null
+++ b/test/fixtures/postman-collection.yml
@@ -0,0 +1,38 @@
+info:
+  name: Sample Postman Collection
+  schema: 'https://schema.getpostman.com/json/collection/v2.1.0/collection.json'
+item:
+  - name: Sample Request
+    request:
+      method: GET
+      header: []
+      url:
+        raw: 'https://jsonplaceholder.typicode.com/posts/1'
+        protocol: https
+        host:
+          - jsonplaceholder
+          - typicode
+          - com
+        path:
+          - posts
+          - '1'
+    response: []
+  - name: Sample POST Request
+    request:
+      method: POST
+      header:
+        - key: Content-Type
+          value: application/json
+      body:
+        mode: raw
+        raw: '{ "title": "foo", "body": "bar", "userId": 1 }'
+      url:
+        raw: 'https://jsonplaceholder.typicode.com/posts'
+        protocol: https
+        host:
+          - jsonplaceholder
+          - typicode
+          - com
+        path:
+          - posts
+    response: []
\ No newline at end of file
diff --git a/test/integration/convert.test.ts b/test/integration/convert.test.ts
index 5fd2bf11454..ec655f778ac 100644
--- a/test/integration/convert.test.ts
+++ b/test/integration/convert.test.ts
@@ -9,6 +9,7 @@ const testHelper = new TestHelper();
 const filePath = './test/fixtures/specification.yml';
 const JSONFilePath = './test/fixtures/specification.json';
 const openAPIFilePath = './test/fixtures/openapi.yml';
+const postmanFilePath = './test/fixtures/postman-collection.yml';
 
 describe('convert', () => {
   describe('with file paths', () => {
@@ -241,4 +242,66 @@ describe('convert', () => {
         done();
       });
   });
+
+  describe('with Postman input', () => {
+    beforeEach(() => {
+      testHelper.createDummyContextFile();
+    });
+  
+    afterEach(() => {
+      testHelper.deleteDummyContextFile();
+    });
+  
+    test
+      .stderr()
+      .stdout()
+      .command(['convert', postmanFilePath, '-f', 'postman-collection'])
+      .it('works when Postman file path is passed', (ctx, done) => {
+        expect(ctx.stdout).to.contain(`🎉 The ${postmanFilePath} file has been successfully converted to asyncapi of version 3.0.0!!`);
+        expect(ctx.stderr).to.equal('');
+        done();
+      });
+  
+    test
+      .stderr()
+      .stdout()
+      .command(['convert', postmanFilePath, '-f', 'postman-collection', '-p=client'])
+      .it('works when Postman file path is passed with client perspective', (ctx, done) => {
+        expect(ctx.stdout).to.contain(`🎉 The ${postmanFilePath} file has been successfully converted to asyncapi of version 3.0.0!!`);
+        expect(ctx.stderr).to.equal('');
+        done();
+      });
+  
+    test
+      .stderr()
+      .stdout()
+      .command(['convert', postmanFilePath, '-f', 'postman-collection', '-p=server'])
+      .it('works when Postman file path is passed with server perspective', (ctx, done) => {
+        expect(ctx.stdout).to.contain(`🎉 The ${postmanFilePath} file has been successfully converted to asyncapi of version 3.0.0!!`);
+        expect(ctx.stderr).to.equal('');
+        done();
+      });
+  
+    test
+      .stderr()
+      .stdout()
+      .command(['convert', postmanFilePath, '-f', 'postman-collection', '-p=invalid'])
+      .it('should throw error if invalid perspective is passed', (ctx, done) => {
+        expect(ctx.stdout).to.equal('');
+        expect(ctx.stderr).to.contain('Error: Expected --perspective=invalid to be one of: client, server');
+        done();
+      });
+  
+    test
+      .stderr()
+      .stdout()
+      .command(['convert', postmanFilePath, '-f', 'postman-collection', '-o=./test/fixtures/postman_converted_output.yml'])
+      .it('works when Postman file is converted and output is saved', (ctx, done) => {
+        expect(ctx.stdout).to.contain(`🎉 The ${postmanFilePath} file has been successfully converted to asyncapi of version 3.0.0!!`);
+        expect(fs.existsSync('./test/fixtures/postman_converted_output.yml')).to.equal(true);
+        expect(ctx.stderr).to.equal('');
+        fs.unlinkSync('./test/fixtures/postman_converted_output.yml');
+        done();
+      });
+  });
 });

From 42713ef2ef26c80a2e3ab50bb9716f6b14a0a03e Mon Sep 17 00:00:00 2001
From: utnim2 <mintugogoi567@gmail.com>
Date: Tue, 24 Sep 2024 16:22:51 +0530
Subject: [PATCH 2/3] refactor the convert.ts

---
 src/commands/convert.ts | 123 ++++++++++++++++++++++++++--------------
 1 file changed, 79 insertions(+), 44 deletions(-)

diff --git a/src/commands/convert.ts b/src/commands/convert.ts
index a528c2c8b80..ba13f327779 100644
--- a/src/commands/convert.ts
+++ b/src/commands/convert.ts
@@ -16,6 +16,8 @@ import { convertFlags } from '../core/flags/convert.flags';
 const latestVersion = Object.keys(specs.schemas).pop() as string;
 
 export default class Convert extends Command {
+  static specFile: any;
+  static metricsMetadata: any = {};
   static description = 'Convert asyncapi documents older to newer versions or OpenAPI/postman-collection documents to AsyncAPI';
 
   static flags = convertFlags(latestVersion);
@@ -42,51 +44,84 @@ export default class Convert extends Command {
       const isAsyncAPI = flags['format'] === 'asyncapi';
 
       // CONVERSION
-      if (isOpenAPI) {
-        convertedFile = convertOpenAPI(this.specFile.text(), specJson.openapi as OpenAPIConvertVersion, {
-          perspective: flags['perspective'] as 'client' | 'server'
-        });
-        this.log(`🎉 The OpenAPI document has been successfully converted to AsyncAPI version ${green(flags['target-version'])}!`);
-      } else if (isAsyncAPI) {
-        convertedFile = convert(this.specFile.text(), flags['target-version'] as AsyncAPIConvertVersion);
-        if (this.specFile.getFilePath()) {
-          this.log(`🎉 The ${cyan(this.specFile.getFilePath())} file has been successfully converted to version ${green(flags['target-version'])}!!`);
-        } else if (this.specFile.getFileURL()) {
-          this.log(`🎉 The URL ${cyan(this.specFile.getFileURL())} has been successfully converted to version ${green(flags['target-version'])}!!`);
-        }
-      } else {
-        convertedFile = convertPostman(this.specFile.text(), '3.0.0', {
-          perspective: flags['perspective'] as 'client' | 'server'
-        });
-        if (this.specFile.getFilePath()) {
-          this.log(`🎉 The ${cyan(this.specFile.getFilePath())} file has been successfully converted to asyncapi of version ${green(flags['target-version'])}!!`);
-        } else if (this.specFile.getFileURL()) {
-          this.log(`🎉 The URL ${cyan(this.specFile.getFileURL())} has been successfully converted to asyncapi of version ${green(flags['target-version'])}!!`);
-        }
-      }
-
-      if (typeof convertedFile === 'object') {
-        convertedFileFormatted = JSON.stringify(convertedFile, null, 4);
-      } else {
-        convertedFileFormatted = convertedFile;
-      }
-
-      if (flags.output) {
-        await fPromises.writeFile(`${flags.output}`, convertedFileFormatted, { encoding: 'utf8' });
-      } else {
-        this.log(convertedFileFormatted);
-      }
+      convertedFile = this.handleConversion(isOpenAPI, isAsyncAPI, flags);
+
+      // Handle file output or log the result
+      convertedFileFormatted = this.formatConvertedFile(convertedFile);
+      await this.handleOutput(flags.output, convertedFileFormatted);
+
     } catch (err) {
-      if (err instanceof SpecificationFileNotFound) {
-        this.error(new ValidationError({
-          type: 'invalid-file',
-          filepath: filePath
-        }));
-      } else if (this.specFile?.toJson().asyncapi > flags['target-version']) {
-        this.error(`The ${cyan(filePath)} file cannot be converted to an older version. Downgrading is not supported.`);
-      } else {
-        this.error(err as Error);
-      }
+      this.handleError(err, filePath ?? "unknown", flags);
+    }
+  }
+
+  // Helper function to handle conversion logic
+  private handleConversion(isOpenAPI: boolean, isAsyncAPI: boolean, flags: any) {
+    const specJson = this.specFile?.toJson();
+    if (isOpenAPI) {
+      return this.convertOpenAPI(specJson, flags);
+    } else if (isAsyncAPI) {
+      return this.convertAsyncAPI(flags);
+    } else {
+      return this.convertPostman(flags);
+    }
+  }
+
+  private convertOpenAPI(specJson: any, flags: any) {
+    const convertedFile = convertOpenAPI(this.specFile?.text() ?? '', specJson.openapi as OpenAPIConvertVersion, {
+      perspective: flags['perspective'] as 'client' | 'server'
+    });
+    this.log(`🎉 The OpenAPI document has been successfully converted to AsyncAPI version ${green(flags['target-version'])}!`);
+    return convertedFile;
+  }
+
+  private convertAsyncAPI(flags: any) {
+    const convertedFile = convert(this.specFile?.text() ?? '', flags['target-version'] as AsyncAPIConvertVersion);
+    if (this.specFile?.getFilePath()) {
+      this.log(`🎉 The ${cyan(this.specFile?.getFilePath())} file has been successfully converted to version ${green(flags['target-version'])}!!`);
+    } else if (this.specFile?.getFileURL()) {
+      this.log(`🎉 The URL ${cyan(this.specFile?.getFileURL())} has been successfully converted to version ${green(flags['target-version'])}!!`);
+    }
+    return convertedFile;
+  }
+
+  private convertPostman(flags: any) {
+    const convertedFile = convertPostman(this.specFile?.text() ?? '', '3.0.0', {
+      perspective: flags['perspective'] as 'client' | 'server'
+    });
+    if (this.specFile?.getFilePath()) {
+      this.log(`🎉 The ${cyan(this.specFile?.getFilePath())} file has been successfully converted to asyncapi of version ${green(flags['target-version'])}!!`);
+    } else if (this.specFile?.getFileURL()) {
+      this.log(`🎉 The URL ${cyan(this.specFile?.getFileURL())} has been successfully converted to asyncapi of version ${green(flags['target-version'])}!!`);
+    }
+    return convertedFile;
+  }
+
+  // Helper function to format the converted file
+  private formatConvertedFile(convertedFile: any) {
+    return typeof convertedFile === 'object' ? JSON.stringify(convertedFile, null, 4) : convertedFile;
+  }
+
+  // Helper function to handle output
+  private async handleOutput(outputPath: string | undefined, convertedFileFormatted: string) {
+    if (outputPath) {
+      await fPromises.writeFile(`${outputPath}`, convertedFileFormatted, { encoding: 'utf8' });
+    } else {
+      this.log(convertedFileFormatted);
+    }
+  }
+
+  // Helper function to handle errors
+  private handleError(err: any, filePath: string, flags: any) {
+    if (err instanceof SpecificationFileNotFound) {
+      this.error(new ValidationError({
+        type: 'invalid-file',
+        filepath: filePath
+      }));
+    } else if (this.specFile?.toJson().asyncapi > flags['target-version']) {
+      this.error(`The ${cyan(filePath)} file cannot be converted to an older version. Downgrading is not supported.`);
+    } else {
+      this.error(err as Error);
     }
   }
 }

From 3fb330db10d064de0c11c63926e51ed52e5add78 Mon Sep 17 00:00:00 2001
From: utnim2 <mintugogoi567@gmail.com>
Date: Tue, 24 Sep 2024 18:14:05 +0530
Subject: [PATCH 3/3] fix some linting problem

---
 src/commands/convert.ts | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/commands/convert.ts b/src/commands/convert.ts
index ba13f327779..499f594d700 100644
--- a/src/commands/convert.ts
+++ b/src/commands/convert.ts
@@ -39,7 +39,6 @@ export default class Convert extends Command {
       this.metricsMetadata.to_version = flags['target-version'];
 
       // Determine if the input is OpenAPI or AsyncAPI
-      const specJson = this.specFile.toJson();
       const isOpenAPI = flags['format'] === 'openapi';
       const isAsyncAPI = flags['format'] === 'asyncapi';
 
@@ -49,9 +48,8 @@ export default class Convert extends Command {
       // Handle file output or log the result
       convertedFileFormatted = this.formatConvertedFile(convertedFile);
       await this.handleOutput(flags.output, convertedFileFormatted);
-
     } catch (err) {
-      this.handleError(err, filePath ?? "unknown", flags);
+      this.handleError(err, filePath ?? 'unknown', flags);
     }
   }
 
@@ -62,9 +60,8 @@ export default class Convert extends Command {
       return this.convertOpenAPI(specJson, flags);
     } else if (isAsyncAPI) {
       return this.convertAsyncAPI(flags);
-    } else {
-      return this.convertPostman(flags);
-    }
+    } 
+    return this.convertPostman(flags);
   }
 
   private convertOpenAPI(specJson: any, flags: any) {