Need for urgent changes in GitHub Actions automation

[derberg]

This issue defines a list of tasks that need to be performed in this repo to make sure it's ci/cd automation works long term without any issues.

It is up to maintainers to decide if it must be addressed in one or multiple PRs.

Below are 3 different sections describing 3 different important ci/cd changes.

IMPORTANT-START
For GitHub workflows that contain This workflow is centrally managed in https://github.com/asyncapi/.github/ you do not have to perform any work. These workflows were already updated through the update in .github. The only exception is the workflows related to nodejs release. More details in Upgrade Release pipeline - in case of nodejs projects section
IMPORTANT-END

Deprecation of way data is shared between steps

Every single GitHub Action workflow that has echo "::set-output name={name}::{value}" need to be updated to follow echo "{name}={value}" >> $GITHUB_OUTPUT

We do not yet know when set-output will stop working. Previous disable date was 31.05 but now then say community needs more time.

For more details read official article from GitHub

Deprecation of node12

2nd bullet point is still relevant for you even if your projects in not nodejs project

• Every single workflow that uses setup-node action needs an update to follow v3 version of this action, and make sure minimum node 14 is used
• Now this part is more complex. Problem with node12 is that node-based GitHub Actions were using it in majority as a runtime environment. Look for example at this action.yaml file for setup-node action v2. So the job that you have to do is go through all the workflows, and verify every single action that you use, make sure you are using the latest version that is not based on node12. I already did review a lot of actions as part of this PR so maybe you will find some actions there and can copy from me. For example action/checkout needs to be updated to v3.

Node12 end of support in action is probably September 27th.

For more details read official article from GitHub

Upgrade Release pipeline - in case of nodejs projects

ignore this section if your project is not nodejs project

You have 2 options. You can:

A. choose to switch to new release pipeline using instruction from asyncapi/.github#205

B. stay with old release pipeline, and manually update GitHub workflows and actions used in it, you can inspire a lot from this PR asyncapi/.github#226

I definitely recommend going with A

Workflows related to release:

• .github/workflows/if-nodejs-release.yml
• .github/workflows/if-nodejs-version-bump.yml
• .github/workflows/bump.yml

[Ruchip16]

Hey @derberg, i would love to work on this 😄

[Souvikns]

We already have the required topics, I think we need to clean the package.json according to asyncapi/.github#205, @Ruchip16 you can go ahead with this.

[Souvikns]

@Ruchip16 do you need any help with this?

[Ruchip16]

@Ruchip16 do you need any help with this?

@Souvikns for the first change i.e Deprecation of way data is shared between steps I would raise a PR soon, but for the cleaning of package.json, can you elaborate more on from where i should start exactly?

[Souvikns]

You can follow asyncapi/.github#205 to clean the package.json file.

[Ruchip16]

You can follow asyncapi/.github#205 to clean the package.json file.

but the package.json file is also already cleaned up in this PR as suggested here: asyncapi/.github#205, I cant see anything that's remaining, can you check once?

[Souvikns]

Yeah, @Ruchip16 this has been fixed, sorry for the confusion since this issue was not mentioned in the PR we had no idea that this was fixed.

[Ruchip16]

Yeah, @Ruchip16 this has been fixed, sorry for the confusion since this issue was not mentioned in the PR we had no idea that this was fixed.

cool, if there is nothing to work upon lets close this issue ?

[KhudaDad414]

@Souvikns @Ruchip16 I am closing this issue since it was opened after we fixed the issue, that's why it is not linked. sorry for the confusion guys.