Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor handlers to separate business logic from generated template #219

Closed
kaushik-rishi opened this issue Aug 15, 2023 · 2 comments
Closed

Refactor handlers to separate business logic from generated template #219

kaushik-rishi opened this issue Aug 15, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@kaushik-rishi
Copy link
Collaborator

Reason/Context

The current nodejs-template can just be generated once. Let's say post generation we add some business logic and then make some changes in the asyncapi file and re-run the generator, our business logic will be overriden.
We have to therefore separate the handlers from the generated template to solve this issue.
WORKING POC: https://github.com/kaushik-rishi/poc-template-aim/blob/master/test.js#L27

Previous Discussions

asyncapi/generator#582 (comment)
@kaushik-rishi kaushik-rishi added the enhancement New feature or request label Aug 15, 2023
@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@kaushik-rishi kaushik-rishi mentioned this issue Aug 15, 2023
Merged
kaushik-rishi pushed a commit to kaushik-rishi/nodejs-template that referenced this issue Aug 23, 2023
@asyncapi-bot
chore: update @asyncapi/generator to 1.9.10 version (asyncapi#219)
605abf8
@kaushik-rishi
Copy link
Collaborator Author

Has been implemented through - #220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kaushik-rishi