Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example definition for message object and message trait should be the same #441

Closed
derberg opened this issue Nov 7, 2023 · 1 comment · Fixed by #536
Closed

Example definition for message object and message trait should be the same #441

derberg opened this issue Nov 7, 2023 · 1 comment · Fixed by #536
Labels
bug Something isn't working stale

Comments

@derberg
Copy link
Member

derberg commented Nov 7, 2023

Imho https://github.com/asyncapi/spec-json-schemas/blob/next-major-spec/definitions/3.0.0/messageObject.json#L73 should be replicated in https://github.com/asyncapi/spec-json-schemas/blob/next-major-spec/definitions/3.0.0/messageTrait.json#L70

cause if somebody will be allowed anything with examples in trait, then trait merging will never work

probably best solution would be to introduce separate reusable MessageExamples.json and reuse it in messageObject.json and messageTrait.json with $ref

@derberg derberg added the bug Something isn't working label Nov 7, 2023
Copy link

github-actions bot commented Mar 7, 2024

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working stale
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant