Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extending Server.variables field type #775

Closed
Tracked by #830
char0n opened this issue May 3, 2022 · 5 comments · Fixed by #842
Closed
Tracked by #830

Extending Server.variables field type #775

char0n opened this issue May 3, 2022 · 5 comments · Fixed by #842

Comments

@char0n
Copy link
Collaborator

char0n commented May 3, 2022

As of version 2.4.0, Server Variable Object can now be defined in Components.serverVariables fixed field, which indicates re-usability. Here is an example that I've took from AsyncAPI 2.4.0 release article.

image

Unfortunately according to the 2.4.0 version of the specification, Server.variables field doesn't allow to use Reference Object:

image

In order to remedy this issue, we have to extend the Server.variables type to Map[string, [Server Variable Object | Reference Object]].


Given we can now define re-usable Server Variable Objects in Components.serverVariables field, we cannot reuse them in any way in 2.4.0 version of the spec.

Ref #707

@char0n
Copy link
Collaborator Author

char0n commented May 3, 2022

I've issued a PR that remedies the situation and would probably suggest to go for 2.4.1 as soon as possible.

@github-actions
Copy link

github-actions bot commented Sep 1, 2022

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 3.0.0-next-major-spec.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This issue has been resolved in version 2.5.0-next-spec.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg
Copy link
Member

derberg commented Jan 31, 2023

Recent comments about the release from the bot were added by mistake. More details in #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants