-
-
Notifications
You must be signed in to change notification settings - Fork 637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug : Footer content not correctly aligned for smaller screen sizes #1676
Comments
Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request. |
@meetagrawal09 i think it's okay the way it is :) or what do you think @akshatnema |
It looks perfect for me. @meetagrawal09 we can't make everything as center aligned. |
@akshatnema i think the News > Email Us section should be aligning with the hamburger icon in the top navigation menu. I understand that it is a minor change |
If you are asking to change the alignment of the icons or content, this is more as a design issue. Any opinions on it @Mayaleeeee? |
Yes, please, @akshatnema. Thanks for tagging me. The News section should be under The Initiatives and not aligned with the hamburger because it's responsive. A quick question: if I detect other bugs under this same footer section, do I need to open a pull request or comment on this? |
Why it should be under The Initiatives? The Initiatives and News are 2 different sections of footer.
@Mayaleeeee You just have to comment on this. No necessity on creating a PR. |
Hey @akshatnema, I apologize if my message was unclear. Let me clarify: I believe it would be beneficial to have the News section positioned below** The Initiatives section**, rather than being placed beside it. By placing the News section under The Initiatives section, it would create a better visual flow, with the social icons following afterwards. I hope my explanation makes sense to you. Like this The Initiatives About News Email Us Social icons |
This issue has been automatically marked as stale because it has not had recent activity 😴 It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation. There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model. Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here. Thank you for your patience ❤️ |
Hello everyone.. @meetagrawal09 can we try something like this |
|
comment them down here only |
@akshatnema I think we can proceed with what @Mayaleeeee has suggested |
Hey @sambhavgupta0705, I would like to take up this issue if no one is working on it.
IMO, Screen 3 seems to be more visually appealing. Otherwise, whatever @Mayaleeeee would suggest. |
Thank you @akkshitgupta Screen 2 is perfect 👌. The center-align for screens 1 and 3 looks odd, so I would prefer screen 2, which is left-aligned. Left-aligning content in a smaller screen for a footer is generally a better practice for readability, aesthetics, and user experience. |
The space between 'AsyncAPI' and the text 'Building...' is too much. Please reduce it by about 40px. Also, when you adjust this spacing, 'The Initiative' and its content should increase. For the spacing between the three sections ('AsyncAPI and the text under is one section,' 'The Initiative and the text under is the second section,' and 'News'), use 32px. Let's see how it looks after these changes. |
I got it @Mayaleeeee, |
@akkshitgupta raise a PR according to the 2nd screen and then we will see what fits here |
No, we don't need to have the 'Socials' title. |
closing as not relevant |
Describe the bug
The footer must have content more centered rather than right aligned for smaller screen sizes.
How to Reproduce
Inspect the site and reduce the window size.
Expected behavior
Footer content should be centered to the page for smaller screen sizes.
The text was updated successfully, but these errors were encountered: