Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug : Footer content not correctly aligned for smaller screen sizes #1676

Closed
meetagrawal09 opened this issue May 16, 2023 · 21 comments
Closed
Labels

Comments

@meetagrawal09
Copy link

Describe the bug

The footer must have content more centered rather than right aligned for smaller screen sizes.

How to Reproduce

Inspect the site and reduce the window size.

image

Expected behavior

Footer content should be centered to the page for smaller screen sizes.

@github-actions
Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@AceTheCreator
Copy link
Member

@meetagrawal09 i think it's okay the way it is :) or what do you think @akshatnema

@akshatnema
Copy link
Member

It looks perfect for me. @meetagrawal09 we can't make everything as center aligned.

@meetagrawal09
Copy link
Author

Just thought if this could make it look better for smaller screens.
image

@luigimorel
Copy link

@akshatnema i think the News > Email Us section should be aligning with the hamburger icon in the top navigation menu. I understand that it is a minor change

Copy link
Member

If you are asking to change the alignment of the icons or content, this is more as a design issue. Any opinions on it @Mayaleeeee?

@Mayaleeeee
Copy link
Member

Mayaleeeee commented May 18, 2023

Yes, please, @akshatnema. Thanks for tagging me.

The News section should be under The Initiatives and not aligned with the hamburger because it's responsive.

A quick question: if I detect other bugs under this same footer section, do I need to open a pull request or comment on this?

Copy link
Member

The News section should be under The Initiatives and not aligned with the hamburger because it's responsive.

Why it should be under The Initiatives? The Initiatives and News are 2 different sections of footer.

if I detect other bugs under this same footer section, do I need to open a pull request or comment on this?

@Mayaleeeee You just have to comment on this. No necessity on creating a PR.

@Mayaleeeee
Copy link
Member

Why it should be under The Initiatives? The Initiatives and News are 2 different sections of footer.

Hey @akshatnema, I apologize if my message was unclear. Let me clarify: I believe it would be beneficial to have the News section positioned below** The Initiatives section**, rather than being placed beside it.

By placing the News section under The Initiatives section, it would create a better visual flow, with the social icons following afterwards. I hope my explanation makes sense to you.

Like this

The Initiatives

About
Blog
Shop
Jobs
Brand

News

Email Us

Social icons

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity 😴

It will be closed in 120 days if no further activity occurs. To unstale this issue, add a comment with a detailed explanation.

There can be many reasons why some specific issue has no activity. The most probable cause is lack of time, not lack of interest. AsyncAPI Initiative is a Linux Foundation project not owned by a single for-profit company. It is a community-driven initiative ruled under open governance model.

Let us figure out together how to push this issue forward. Connect with us through one of many communication channels we established here.

Thank you for your patience ❤️

@github-actions github-actions bot added the stale label Sep 17, 2023
@KaalCodes
Copy link

KaalCodes commented Nov 13, 2023

Hello everyone.. @meetagrawal09 can we try something like this
Sample_Colabse_Final__

@Mayaleeeee
Copy link
Member

Why it should be under The Initiatives? The Initiatives and News are 2 different sections of footer.

Hey @akshatnema, I apologize if my message was unclear. Let me clarify: I believe it would be beneficial to have the News section positioned below** The Initiatives section**, rather than being placed beside it.

By placing the News section under The Initiatives section, it would create a better visual flow, with the social icons following afterwards. I hope my explanation makes sense to you.

Like this

The Initiatives

About
Blog
Shop
Jobs
Brand

News

Email Us

Social icons

@sambhavgupta0705

@sambhavgupta0705
Copy link
Member

A quick question: if I detect other bugs under this same footer section, do I need to open a pull request or comment on this?

comment them down here only

@sambhavgupta0705
Copy link
Member

@akshatnema I think we can proceed with what @Mayaleeeee has suggested

@akkshitgupta
Copy link
Contributor

akkshitgupta commented Mar 5, 2024

Hey @sambhavgupta0705, I would like to take up this issue if no one is working on it.
Here are the 3 ways we can arrange the two sections

Screen 1 Screen 2 Screen 3
image image image

IMO, Screen 3 seems to be more visually appealing. Otherwise, whatever @Mayaleeeee would suggest.

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Mar 6, 2024

Hey @sambhavgupta0705, I would like to take up this issue if no one is working on it.
Here are the 3 ways we can arrange the two sections

Screen 1 Screen 2 Screen 3
image image image

IMO, Screen 3 seems to be more visually appealing. Otherwise, whatever @Mayaleeeee would suggest.

Thank you @akkshitgupta

Screen 2 is perfect 👌. The center-align for screens 1 and 3 looks odd, so I would prefer screen 2, which is left-aligned. Left-aligning content in a smaller screen for a footer is generally a better practice for readability, aesthetics, and user experience.

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Mar 6, 2024

Hey @sambhavgupta0705, I would like to take up this issue if no one is working on it.
Here are the 3 ways we can arrange the two sections

Screen 1 Screen 2 Screen 3
image image image

IMO, Screen 3 seems to be more visually appealing. Otherwise, whatever @Mayaleeeee would suggest.

Thank you @akkshitgupta

Screen 2 is perfect 👌. The center-align for screens 1 and 3 looks odd, so I would prefer screen 2, which is left-aligned. Left-aligning content in a smaller screen for a footer is generally a better practice for readability, aesthetics, and user experience.

The space between 'AsyncAPI' and the text 'Building...' is too much. Please reduce it by about 40px.

Also, when you adjust this spacing, 'The Initiative' and its content should increase. For the spacing between the three sections ('AsyncAPI and the text under is one section,' 'The Initiative and the text under is the second section,' and 'News'), use 32px.

Let's see how it looks after these changes.

Screenshots_2024-03-06-01-24-21.png

@akkshitgupta
Copy link
Contributor

I got it @Mayaleeeee,
I would push the changes in the next hour. Just wanna confirm if it would be ok to show the socials title as in screen 3

@sambhavgupta0705
Copy link
Member

@akkshitgupta raise a PR according to the 2nd screen and then we will see what fits here

@Mayaleeeee
Copy link
Member

Mayaleeeee commented Mar 6, 2024

I got it @Mayaleeeee,
I would push the changes in the next hour. Just wanna confirm if it would be ok to show the socials title as in screen 3

No, we don't need to have the 'Socials' title.
But if it's on the desk view, then it's totally fine.

@sambhavgupta0705
Copy link
Member

closing as not relevant

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
8 participants