Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Implement Dark Mode Theme Support. #3342

Closed
2 tasks done
prashantrai-30 opened this issue Oct 29, 2024 · 3 comments
Closed
2 tasks done

[FEATURE] Implement Dark Mode Theme Support. #3342

prashantrai-30 opened this issue Oct 29, 2024 · 3 comments

Comments

@prashantrai-30
Copy link

Why do we need this improvement?

  • Current Limitations ⚠️

    • Only light mode available
    • Difficult to use in low-light environments
    • Limited accessibility options
  • User Feedback 👥

    • Frequent requests for dark mode
    • Reports of eye strain during night usage
    • Accessibility concerns from users
  • Market Analysis 📊

    • Standard feature in competitor APIs
    • Present in major development tools
    • Growing user expectation

How will this change help?

  • Solution Impact 🎯

    • System-level theme detection
    • Seamless mode switching
    • Persistent user preferences
  • Direct Benefits

    • Reduced eye strain in low light
    • Better readability at night
    • Lower battery consumption on OLED displays
  • Implementation Value 🔨

    • Standardized color variables
    • Consistent UI components
    • Future-proof theming system
  • Business Metrics 📈

    • Increased user satisfaction
    • Better platform accessibility
    • Improved market competitiveness

Screenshots

No response

How could it be implemented/designed?

  • Create theme context/provider
  • Define CSS variables for theming
  • Add theme toggle component
  • Implement system theme detection
  • Add local storage persistence
  • Update existing components to use theme variables

🚧 Breaking changes

Yes

👀 Have you checked for similar open issues?

  • I checked and didn't find a similar issue

🏢 Have you read the Contributing Guidelines?

Are you willing to work on this issue?

Yes I am willing to submit a PR!

Copy link

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@vishvamsinh28
Copy link
Contributor

We already have an issue open for this and a PR for it also opened

@sambhavgupta0705
Copy link
Member

closing this as duplicate

@sambhavgupta0705 sambhavgupta0705 closed this as not planned Won't fix, can't repro, duplicate, stale Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants