Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Over use of dictionaries #10

Open
atfrank opened this issue Oct 11, 2019 · 0 comments
Open

Over use of dictionaries #10

atfrank opened this issue Oct 11, 2019 · 0 comments
Assignees

Comments

@atfrank
Copy link
Owner

atfrank commented Oct 11, 2019

The current code source predicted chemical shifts in a nested dictionary. The overuse of dictionaries can result in slow code. We should consider rewriting the code to use pandas dataFrames. Indeed, when reading from an external file, the predicted chemical shifts are stored in a pandas dataFrame. Why not just reference that data, instead of first extracting the data from the dataFrame and storing them in a dictionary.

@atfrank atfrank self-assigned this Oct 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant