Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ensure athena is not relying on en0 network device for host ip #44

Open
savar opened this issue Apr 28, 2017 · 1 comment
Open

ensure athena is not relying on en0 network device for host ip #44

savar opened this issue Apr 28, 2017 · 1 comment

Comments

@savar
Copy link
Contributor

savar commented Apr 28, 2017

in https://github.com/athena-oss/athena/blob/master/lib/shared/functions.os.sh#L603 the _get_host_ip_for_mac is expecting the host IP on device en0 which is not always the same. To improve this situation we should at least (thinking of IPv4/v6) go through en* and take the first private IPv4 address we find
@bassco
Copy link
Contributor

bassco commented May 10, 2017

@savar see PR #46 for a possible solution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@savar @bassco