Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review all keybindings before releasing 3.0 #2628

Closed
aadcg opened this issue Nov 7, 2022 · 3 comments · Fixed by #2942
Closed

Review all keybindings before releasing 3.0 #2628

aadcg opened this issue Nov 7, 2022 · 3 comments · Fixed by #2942
Labels
3-series Related to releases whose major version is 3.

Comments

@aadcg
Copy link
Member

aadcg commented Nov 7, 2022

Adding it as a reminder.

@aartaka advocated for rebinding set-action-on-return (ex return-selection-over-actions).

set-action-on-return (ex return-selection-over-action) should be bound to shift-return instead of M-return. The latter should be reserved for "strong" actions that close the prompt-buffer, analogous to return and C-return (return stands either for "activate this now" or "I'm done, commit this action" in CUA). If we dilute the responsibility one takes when pressing M-return, then the character of other actions bound to *-return will not be perceived as final and decisive for a given prompt.

@aadcg aadcg added the 3-series Related to releases whose major version is 3. label Nov 7, 2022
@aartaka
Copy link
Contributor

aartaka commented Nov 7, 2022

Maybe shift-return is too strong too, by the way!

@aadcg
Copy link
Member Author

aadcg commented Mar 23, 2023

Any update here @aartaka? Do we still want to change this keybinding?

@aartaka
Copy link
Contributor

aartaka commented Mar 24, 2023

I still think we should change the keybinding, and s-return sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3-series Related to releases whose major version is 3.
Development

Successfully merging a pull request may close this issue.

2 participants