Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use set-url or set-url-from-current-url by default? #969

Closed
Ambrevar opened this issue Sep 25, 2020 · 8 comments
Closed

Use set-url or set-url-from-current-url by default? #969

Ambrevar opened this issue Sep 25, 2020 · 8 comments

Comments

@Ambrevar
Copy link
Member

See #949 for a discussion.

@aadcg
Copy link
Member

aadcg commented Oct 21, 2020

I think set-url-from-current-url makes more sense by default, since that's how most popular browers behave. This is the current behaviour, so there's nothing to do here. Feel free to close this issue, if you have nothing more to add.

@Ambrevar
Copy link
Member Author

In a regular browser, pressding C-l selects the URL from the bar and the next editing key replaces the URL.
We don't support this behaviour at the moment.

To add such support, we would need more advanced text editing features such as text highlighting.

@jmercouris
Copy link
Member

I agree with both of you. I think that set-url-from-current-url is what users expect, however, we should have the mark on the whole text body so that the user can replace it with a single key.

@jmercouris
Copy link
Member

So, my personal conclusion: set-url-from-current-url as default, WHEN we have the ability to highlight text.

@aadcg
Copy link
Member

aadcg commented Nov 12, 2020

Is anyone working on text highlighting?

@Ambrevar
Copy link
Member Author

Ambrevar commented Nov 12, 2020 via email

@aadcg
Copy link
Member

aadcg commented Nov 13, 2020

Woow, lots of cool ideas and lots of work ahead.

If I can be of any help, let me know. I'm wondering if there's work I could do on #1027 that could help you.

@jmercouris
Copy link
Member

This is now the new default :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants