Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Tags containing ":" or "-" for example are not matched properly #353

Open
1 task done
surdu opened this issue Jul 2, 2018 · 1 comment
Open
1 task done

Tags containing ":" or "-" for example are not matched properly #353

surdu opened this issue Jul 2, 2018 · 1 comment

Comments

@surdu
Copy link

surdu commented Jul 2, 2018

Edit by @rsese to flesh out issue template

Prerequisites

Description

XML tags containing ":" are not matched properly.

screen shot 2018-04-26 at 12 00 44

As you can see, the closing tag was mismatched. It should have underlined the last tag, not the one it did.

Steps to Reproduce

atom --safe:

  1. Create test.xml with this content:
<?xml version="1.0" encoding="UTF-8"?>
  <absolutelayout row="0">
    <c:Card>
      <c:Card.content>
        <Label text="Some text" />
      </c:Card.content>
    </c:Card>
  </absolutelayout>
  1. Put the cursor on <c:Card> on line 3

Expected behavior: [What you expect to happen]

Expect </c:Card> on line 7 to be highlighted.

Actual behavior: [What actually happens]

</c:Card.content> on line 6 is highlighted.

Reproduces how often: [What percentage of the time does it reproduce?]

100%

Versions

atom -v
Atom    : 1.30.0-dev-ea9b7cee4
Electron: 2.0.3
Chrome  : 61.0.3163.100
Node    : 8.9.3

macOS 10.12.6

Additional Information

If you remove the : in <c:Card> and </c:Card>, the tags highlight correctly.

Similar/same issue with camelCase? #388


screen shot 2018-04-26 at 12 00 44

As you can see, the closing tag was mismatched. It should have underlined the last tag, not the one it did.

I know this in not common tag-ing for XML but when working with NativeScript it's quite common.

Versions:
Atom: 1.29.0-beta0
bracket-matcher: 0.89.2

@rsese
Copy link

rsese commented Jul 2, 2018

Thanks for the report - I was positive that this has been reported before but I couldn't find the other issue. I went ahead and fleshed out the issue body, please use the issue template for future issues.

@rsese rsese added the triaged label Jul 2, 2018
@rsese rsese changed the title XML tags containing ":" are not matched properly Tags containing ":" or "-" for example are not matched properly Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants