Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve package quality #7

Open
burhankhanzada opened this issue Jan 20, 2024 · 2 comments
Open

Improve package quality #7

burhankhanzada opened this issue Jan 20, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@burhankhanzada
Copy link

burhankhanzada commented Jan 20, 2024

Hi @atreeon this is awesome package but i find some room to improve as mentioned below.

  1. As some tests like example 8 of enums which generate .g.dart which we should ignore in gitignore.
  2. Single readme on repo root and use same on github and pub packages using symbolic link.
  3. Use mono repo managing tool like melos which help release package, aut update version number and Changelog file than using custom shell script.
@atreeon
Copy link
Owner

atreeon commented Jan 23, 2024

Hey @burhankhanzada thanks so much, I'll do this. Good idea re the symlink. I'll check the example 8 and the .g file.

@atreeon atreeon added the enhancement New feature or request label Jan 23, 2024
@burhankhanzada
Copy link
Author

Well if you allow me i can do that.I really want to contribute to this package and it's the simple thing that i understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants