Skip to content
This repository has been archived by the owner on Feb 8, 2019. It is now read-only.

Use SerialDisposable in Concat() implementation. #10

Open
atsushieno opened this issue Jan 29, 2012 · 2 comments
Open

Use SerialDisposable in Concat() implementation. #10

atsushieno opened this issue Jan 29, 2012 · 2 comments

Comments

@atsushieno
Copy link
Owner

Currently we use CompositeDisposable to handle disposables from IObservable.Subscribe() on each IObservable object. This is not effective and it should be possible to use SerialDisposable instead. However, somehow that class does not work.

It could be a bug in SerialDisposable, or wrong usage in Concat() implementation.

@atsushieno
Copy link
Owner Author

The problem seems gone.

@atsushieno
Copy link
Owner Author

Actually I had to revert this back. For some reason, it is likely that some concatenated IObservable's Subscribe() result is set to SerialDisposable.Disposable in unexpected order, so that the sequence is disposed before iterating to the next observable.

I have added a test case as HistoricalSchedulerTest.AdvanceByRaisesEvent2() that uncovered this implementation issue (though I cannot identify which part of the library code is problematic).

@atsushieno atsushieno reopened this Feb 5, 2012
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant