Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dispose GltfImport (only) while keeping instances intact #179

Open
Tracked by #739
atteneder opened this issue May 12, 2021 · 1 comment
Open
Tracked by #739

Dispose GltfImport (only) while keeping instances intact #179

atteneder opened this issue May 12, 2021 · 1 comment
Labels
enhancement New feature or request import Import of glTF files refactor Code base improvements, not necessarily feature/API changes. run-time

Comments

@atteneder
Copy link
Owner

After all desired instantiations are done, the GltfImport could be Disposed. The current mechanism would dispose resources (like materials, meshes and textures) as well, breaking all instances.

An alternative Dispose that leaves instances intact could free up some memory.
@atteneder atteneder added the enhancement New feature or request label May 12, 2021
@atteneder atteneder mentioned this issue May 12, 2021
Closed
@atteneder atteneder added the import Import of glTF files label Dec 1, 2021
@atteneder atteneder mentioned this issue Jun 1, 2022
Closed
@atteneder atteneder moved this to Runtime Loading in glTFast development Jun 25, 2024
atteneder added a commit to Unity-Technologies/com.unity.cloud.gltfast that referenced this issue Sep 5, 2024
@atteneder @Hugo-Didimo
feat(export): Skinning export support (atteneder#179)
a9923bd 
* The hierarchy is now first converted to nodes before actually adding components to nodes. This ensures joint nodes have already been added.

* fix: Updated export references.
* Camera/light orientation nodes are added at last now.
* Buffer view targets are added now.

* fix: Fixed layer mask test and updated referenences.

* fix: Skip skin when not all bone transforms are exported as well.

* fix: Draco compressed skin export.

* doc: Updated features page.

---------

Co-authored-by: Hugo Pereira <[email protected]>
@atteneder
Copy link
Owner Author

This should be tackled/considered as part of #739.

@atteneder atteneder added the refactor Code base improvements, not necessarily feature/API changes. label Dec 10, 2024
@atteneder atteneder mentioned this issue Dec 10, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request import Import of glTF files refactor Code base improvements, not necessarily feature/API changes. run-time
Projects
glTFast development
Status: Planned
Milestone
No milestone
Development

No branches or pull requests
1 participant
@atteneder