Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating New Logic on VRSide for all Server-Based Connections #156

Open
5 of 9 tasks
jasmine-bae opened this issue Oct 10, 2020 · 0 comments
Open
5 of 9 tasks

Updating New Logic on VRSide for all Server-Based Connections #156

jasmine-bae opened this issue Oct 10, 2020 · 0 comments
Assignees
Labels
Milestone

Comments

@jasmine-bae
Copy link
Collaborator

jasmine-bae commented Oct 10, 2020

i.e. depreciating all the ROS Connections and subscribers on Unity and making it work w/o it

Droneproperties.cs

  • Get rid of rosdroneconnection (more issues following :) )
    *note: SERVERSIDE should keep state of the drone rather than in here

Dronemenu.cs

  • Initialize menu without rosdroneconnection interfaces or ros connections in general
  • For getting lat/long/gps position/other drone menu items: we connect to ROStopic directly for these items.
  • Might need to be connected in serverconnections.cs
  • note* can be done easily (set it up that way), just needs to figure out how to get information about the drone normally found in rosdroneconnectioninterfaces, which are "hasauthority" and other state variables.

Waypoint.cs

  • Reference drone should be updated to drone_v2 but it might break stuff (i.e. when its called to super-class)
  • mydrone is currently casted to Drone_v2 to hold off from breaking stuff
  • used add operator -> needs to be downcasted. If not, it will cause a whole issue where Drone has parameters and attributes that Drone_v2 does not have (i.e. the addwaypoint and other waypoint functions in Drone might be set to some variables/hold info that creating a new Drone_v2 might lose) (Eric said this should work)
  • test new waypoint functions/everything changed in VR @PeruDayani

WaypointProperties.cs

  • Reference drone should be updated to drone_v2 but it might break stuff (i.e. when its called to super-class)

*note: drone subscribers is a whole 'nother issue
Drone.cs

  • sensor subscribers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants