Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data not being bound to DOM when array is changed. #98

Closed
chuckwatson87-zz opened this issue Dec 12, 2016 · 4 comments
Closed

Data not being bound to DOM when array is changed. #98

chuckwatson87-zz opened this issue Dec 12, 2016 · 4 comments
Labels
bug

Comments

@chuckwatson87-zz
Copy link
Contributor

I'm submitting a bug report

  • Library Version:
    1.0.0-beta.3.0.2

Please tell us about your environment:

  • Operating System:
    Windows 10

  • Node Version:
    6.8.1

  • NPM Version:
    3.10.8
  • Browser:
    Chrome 54.0.2840.99 (only one I've tested in so far)
  • Language:
    all | TypeScript X.X | ESNext

Current behavior:
I have an array of around 300 elements. This array is filtered based on what a user types in a textbox. If I don't scroll. This seems to work perfectly. If I scroll about halfway down, and type in the search textbox, it looks like it is bringing back the correct results when I look in the console, but they are not being bound to the DOM properly. So if it is only supposed to show, say 13, results, I will see 13 list items, on the page, but no data.

I have created a repository here for the issue: https://github.com/chuckwatson87/au-virtualization-refresh-issues

And here is a GitHub Pages site for it: https://chuckwatson87.github.io/au-virtualization-refresh-issues/index.html.

The easiest way I've been able to recreate this behavior is to is to scroll down about halfway, and type "ann" in the textbox.

Expected/desired behavior:

  • What is the expected behavior?
    For it to return the data with no binding issues

  • What is the motivation / use case for changing the behavior?
    User searching and filtering a big list frequently.
@EisenbergEffect
Copy link
Contributor

Ping @martingust @AStoker

@chuckwatson87-zz
Copy link
Contributor Author

FYI, this issue seems similar to the issues that are being addressed with pull requests 99 and 96. I will re-test once those are merged in.

@AStoker
Copy link
Contributor

AStoker commented Mar 27, 2017

Related to: #106
Working on resolving there.

AStoker added a commit to AStoker/ui-virtualization that referenced this issue Mar 31, 2017
@AStoker
fix(virtual-repeat): handle array changes correctly
b861aa6 
Resolves: aurelia#106, aurelia#98, aurelia#89
Previous behavior did not handle array changes correctly (in particular
changes with the size of the array). Behavior now allows for array
changes with different sizes, and should keep appropriate scroll
positions.
@AStoker AStoker mentioned this issue Mar 31, 2017
Merged
@AStoker
Copy link
Contributor

AStoker commented Apr 5, 2017

Resolved by #107

@AStoker AStoker closed this as completed Apr 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@EisenbergEffect @AStoker @chuckwatson87-zz