Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add docker image #33

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

add docker image #33

wants to merge 4 commits into from

Conversation

riyavsinha
Copy link
Contributor

No description provided.

@austintwang
Copy link
Owner

Thanks, this looks great!

One issue though is that the dev branch is currently a bit ahead of the main branch, including the dependencies (polars v1 introduces some breaking changes). Do you mind creating a PR for dev targeting the packages there? Then, I can push everything to main.

@riyavsinha
Copy link
Contributor Author

So, the :dev in kundajelab/finemo_gpu:dev referes to the "tag" of the docker image, not the github branch its being built from. The same Dockerfile can be used on the main branch vs the dev branch vs any other git branch to build the image, because its just a recipe for how to install, and that recipe is using whatever the conda environment.yml specifies.

I did change the docs though to instruct how to build/pull from the default tag though (just kundajelab/finemo_gpu)!

Happy to clarify further also :)

@austintwang
Copy link
Owner

Gotcha, thanks for clarifying!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants