Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security issues with deep dependencies #175

Open
guyindepurker opened this issue Oct 19, 2022 · 2 comments
Open

Security issues with deep dependencies #175

guyindepurker opened this issue Oct 19, 2022 · 2 comments

Comments

@guyindepurker
Copy link

guyindepurker commented Oct 19, 2022

Hi we use the latest version of passport-wsfed-saml2 4.6.1 and we has a Security issues with the dependencies that you use and you should to update the version of them in the package.json of the library.

this is the list under "via" that you should to update:
"passport-wsfed-saml2": { "name": "passport-wsfed-saml2", "severity": "critical", "isDirect": true, "via": [ "ejs", "node-forge", "xml-crypto", "xml-encryption" ] },

Its seems that the ejs and node-forge that you used is the most critical.
You can check this and release new version of passport-wsfed-saml2.
Or you can tell me what to do with this?

@allens01
Copy link

allens01 commented Mar 1, 2023

I have got around this by setting overrides in package.json (or resolutions if you are using yarn)

"overrides": { "xml-encryption": "3.0.1", "node-forge": "1.3.1", "xml-crypto": "2.1.5", "ejs": "3.1.8" }

@nrcdvyskrebets
Copy link

here's my package.json with bumps for the latest version as of now

{
  "dependencies": {
    "passport-wsfed-saml2": "4.6.3"
  },
  "overrides": {
    "[email protected]": {
      "ejs": "3.1.7",
      "node-forge": "1.3.0",
      "xml-crypto": "2.1.5"
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants