Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Allow any" option in allowed lists should be explicitly set #423

Open
cam-schultz opened this issue Aug 9, 2024 · 0 comments
Open

"Allow any" option in allowed lists should be explicitly set #423

cam-schultz opened this issue Aug 9, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@cam-schultz
Copy link
Collaborator

Context and scope
Currently, an empty allowed-origin-sender-addresses or supported-destinations is used to indicate that there are no restrictions on allowed senders or destinations. Under the hood, this writes to a concrete DB key that can cause surprising behavior in some scenarios.

Discussion and alternatives
To mitigate against any surprises, we should change the semantics of the allowed lists such that an empty list corresponds to no allowed senders/destinations. In order to allow any sender/destination, an entry must be explicitly provided in those lists.

Open questions

  • What key should we use for the "allow any" case? Currently, this case translates to the zero address/empty blockchain ID, but there are scenarios in which these zero values are explicitly set in Warp messages.
  • How should we validate the config? If the "allow any" key is provided, should we disallow any other concrete entries?
@cam-schultz cam-schultz added the enhancement New feature or request label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Backlog 🗄️
Development

No branches or pull requests

1 participant