Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run e2e suite only if relevant contracts changed #601

Open
cam-schultz opened this issue Oct 14, 2024 · 0 comments
Open

Run e2e suite only if relevant contracts changed #601

cam-schultz opened this issue Oct 14, 2024 · 0 comments
Labels

Comments

@cam-schultz
Copy link
Contributor

Context and scope
The separated e2e test suites introduced in #592 allow each suite to be run simultaneously and in isolation. However, the validator-manager suite in particular is long running, and it is unnecessary to run those tests if, say, a PR only changes the teleporter contracts.

Discussion and alternatives
We should separate the e2e jobs in the test workflow such that each suite only runs if files in the corresponding subdirectory of contracts are changed. We should still run all tests on merging to main.

The [paths](https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#onpushpull_requestpull_request_targetpathspaths-ignore) syntax can be used to define these filters at the workflow level. Something like https://github.com/tj-actions/changed-files?tab=readme-ov-file can be used to do this at the job level.

Open questions
Questions that are still being discussed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Backlog 🗄️
Development

No branches or pull requests

1 participant