From 7d1c794785490cef05b0c796f0ab3b9a42ac3c33 Mon Sep 17 00:00:00 2001 From: "yu.wang" <29392414+ZedRover@users.noreply.github.com> Date: Wed, 20 Mar 2024 05:40:29 +0000 Subject: [PATCH] fix(WandbFluxTrainingExt.jl, WandbMPIExt.jl, main.jl): replace finish to close --- ext/WandbFluxTrainingExt.jl | 2 +- ext/WandbMPIExt.jl | 2 +- src/main.jl | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/ext/WandbFluxTrainingExt.jl b/ext/WandbFluxTrainingExt.jl index 2ca71bb..af7ae79 100644 --- a/ext/WandbFluxTrainingExt.jl +++ b/ext/WandbFluxTrainingExt.jl @@ -13,7 +13,7 @@ function Base.close(wa::Wandb.WandbBackend, args...; kwargs...) return close(wa.logger, args...; kwargs...) end -for func in (:log, :update_config!, :finish, :save, :get_config) +for func in (:log, :update_config!, :close, :save, :get_config) @eval begin function Wandb.$(func)(wa::Wandb.WandbBackend, args...; kwargs...) return Wandb.$(func)(wa.logger, args...; kwargs...) diff --git a/ext/WandbMPIExt.jl b/ext/WandbMPIExt.jl index 946a86a..2e0b895 100644 --- a/ext/WandbMPIExt.jl +++ b/ext/WandbMPIExt.jl @@ -57,7 +57,7 @@ for func in (:log, :close) end end -for func in (:increment_step!, :finish, :save) +for func in (:increment_step!, :close, :save) @eval begin function Wandb.$(func)(wa::WandbLoggerMPI, args...; kwargs...) return Wandb.$(func)(wa.logger, args...; kwargs...) diff --git a/src/main.jl b/src/main.jl index f88f483..c6ec25a 100644 --- a/src/main.jl +++ b/src/main.jl @@ -83,7 +83,7 @@ end Terminate the current run. For more details checkout `wandb.finish` (or `? Wandb.wandb.finish` in the Julia REPL). """ -Base.close(lg::WandbLogger; kwargs...) = lg.wrun.finish(; kwargs...) +Base.close(lg::WandbLogger; kwargs...) = lg.wrun.close(; kwargs...) """ save(lg::WandbLogger, args...; kwargs...)