-
Notifications
You must be signed in to change notification settings - Fork 343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recipe resolver resolves non-existent tests #5924
Comments
So there are a few possibilities here which can even be complementary: Show where the resolution is coming from In the case of having a good (`/tmp/good.json'): {"kind": "avocado-instrumented", "uri": "examples/tests/passtest.py:PassTest.test"} and {"kind": "avocado-instrumented", "uri": "examples/tests/passtes.py:PassTest.test"} When doing a verbose list we currently have:
What we could have is:
A two-phase resolver feature It maybe limited to resolvers such as
{"kind": "avocado-instrumented", "uri": "examples/tests/passtest.py:PassTest.test"}
|
When using some of the new resolvers such as "runnable-recipe", there's no longer a 1:1 relationship that the resolver and the "kind" match. Certain types of resolution may look fine from the perspective of the original resolver, while it may be a broken or invalid reference to a more apt (or canonical) resolver for its set "kind". By listing the original resolver, users may be able to more easily identify what the discrepancy is and where it's coming from. Reference: avocado-framework#5924 Signed-off-by: Cleber Rosa <[email protected]>
When using some of the new resolvers such as "runnable-recipe", there's no longer a 1:1 relationship that the resolver and the "kind" match. Certain types of resolution may look fine from the perspective of the original resolver, while it may be a broken or invalid reference to a more apt (or canonical) resolver for its set "kind". By listing the original resolver, users may be able to more easily identify what the discrepancy is and where it's coming from. Reference: avocado-framework#5924 Signed-off-by: Cleber Rosa <[email protected]>
Hi @clebergnu thank you for detailed description of possible solutions. Even tho I would like to have more robust solution, I think that two-phase resolver feature would add more complexity to resolvers implementation, and it will increase learning curve for avocado users, therefore I am satisfied with the first solution resolved in #5951. IMO, we can close this and come back in the future if it's needed. |
Closing as resolved in #5951. |
Describe the bug
When you make a mistake in a test uri in a recipe file, avocado will resolve this file without any issues. This bug makes avocado raise errors during test runtime.
Steps to reproduce
recipe file with wrong uri:
Expected behavior
Current behavior
The text was updated successfully, but these errors were encountered: