-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can this repo be removed / deprecated? #6
Comments
Same story as awesomeWM/oopango#1. Let us keep the discussion here. |
s/here/there/ ?
|
Can I ask why should this be deprecated? Is there another, more up-to-date, repo anywhere, or is the library itself deprecated? |
I only looked into this for awesome and awesome uses LGI instead of this (much more powerful and easier to maintain). @Nixola What are you using this for? |
I'm using it in order to render things (lines, mostly) on a server (thus with no GPU or X server or screen or anything). Now if only I could get it running on said server ( |
Assuming you are talking about LGI: Look for a package like cairo-gobject... uhm libcairo-gobject2 |
Wait, no, you are not talking about LGI, but about oocairo? libcairo2-dev: https://packages.debian.org/stretch/libcairo2-dev |
Welp. I installed it and could configure (I was talking about oocario), but make says "Nothing to be done for 'all'.", so I kind of can't build it? Also, I kind of haven't ever heard of LGI; does it use Cairo as well, or does it allow me to render things to an image with no graphics context or device? |
Dunno about the "nothing to be done". That LGI-one should be fixed by installing libcairo-gobject2, but yeah, you are right about scope. :-) |
I'm insterested in using oocairo and, if necessary, improving it. E.g. providing a rockspec and submitting it to luarocks. Also a new version number for current master would be useful. Are you accepting pull requests? Or should this repo be considered as dead/frozen? |
@osch Any specific reason why you prefer oocairo over lgi? It depends on how much work you want to do on oocairo. The simplest option might be to just fork this. |
First of all I want to have as less dependencies as possible to other libraries and especially are trying to avoid gnome related stuff (gnome projects lost backward compatibility in the past too often, latest example pango 1.44).
Yes, I also thought about this but before doing so, I wanted to clarify the status of this repo to avoid unnecessary forks. If I'm going to fork I'm also undecided if the fork should have a different name or just keep the name oocairo (both variants could cause confusion somehow). |
On the C side, just use create an extra reference and use On the Lua side, use the "constructor" of the respective type, e.g. With LGI, this is totally not type safe while (AFAIR) oocairo requires the C code to do stuff in a type safe way... I propose that you just send PRs here and if you decide that I am too slow in merging (or complain too much), you can still fork. Note that this is already a fork of another project which was already called oocairo, but I do not remember the details of where that code came from. And I have not looked at this oocairo in ages. |
Yes oocairo is safer here because full lua userdata is used instead of lightuserdata, so this is IMHO an additonal reason for using oocairo.
OK, but in the first place it would be good if you could tag current master as |
Feel free to do this. I never uploaded anything to luarocks before.
Which version do you mean exactly with current master? Looking at the git history, I guess I should do something similar to 3eef5d8 (wow, it's been almost nine years since 1.4). |
wow now it's going faster than I imagined: yes it would be cool to include my latest PR, so I would tag after
ah yes, you are right, this must be done before tagging. I would than prepare & test a rockspec for version 1.5 and also a PR for the versioned rockspec, although the PR is not necessary but just for completeness. Regarding the 1.5 rockspec this is a hen-and-egg problem: the 1.5 rockspec can only be tested after 1.5 is tagged. But I don't see any problems if the 1.5 rockspec is not included in the tag. Perhaps it's also silly to commit the versioned rockspec at all, I'm not sure about this. |
@osch Done |
No description provided.
The text was updated successfully, but these errors were encountered: