Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Icon Margin Request / Wrong Rating shown #44

Open
UGU-Academy opened this issue Mar 2, 2023 · 0 comments
Open

Add Icon Margin Request / Wrong Rating shown #44

UGU-Academy opened this issue Mar 2, 2023 · 0 comments

Comments

@UGU-Academy
Copy link

UGU-Academy commented Mar 2, 2023

Problem: if you want to add custom margin to your icons you can't do it properly.
You can set margin on the icon itself, like wrap it in another span and give it a margin, but that will brake the precision of the icons shown.

Here is the example: I've given a marginRight to my custom icon and I've set initialValue to 3.5:
image

I can give a padding to my custom icon and it will correctly show values with .5 , but if we have .2 or .7 it will not look precisely.

I assume that right now this library simply creates 2 divs one with empty and one with filled icons and later on based on the initialValue make them overlap to some extend.

So, if you make a margin between icons it will brake the precision.

My suggestion is to fill each icon separately:
If initialValue is for example 3.3 - it will fill each icon separately: 3 will be filled and one will be filled only for 30%. This will still work if you have 10 icons.
Also, we will need to add new properties to the lib: iconMarginRight & iconMarginLeft - which will enable developers to set custom margins on the icon.

Let me know if this can be implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant